Progress.

Author: davidmorgan

build_resolvers/lib/src/analysis_driver_model.dart

@@ -122,8 +122,9 @@ class AnalysisDriverModel {
       idsToSyncOntoFilesystem = await _log.attributeAsync(
         Attribution.track,
         () async {
-          // Note: `transitiveDepsOf` can cause loads that cause builds that cause a
-          // recursive `_performResolve` on this same `AnalysisDriver` instance.
+          // Note: `transitiveDepsOf` can cause loads that cause builds that
+          // cause a recursive `_performResolve` on this same `AnalysisDriver`
+          // instance.
           final nodeLoader = AssetDepsLoader(buildStep.phasedReader);
           buildStep.inputTracker.addResolverEntrypoint(entrypoint);
           return await _graphLoader.transitiveDepsOf(nodeLoader, entrypoint);

build_runner/lib/src/build_script_generate/bootstrap.dart

@@ -117,10 +117,12 @@ Future<int> _generateAndRun(
     } on IsolateSpawnException catch (e) {
       if (tryCount > 1) {
         _log.severe(
-          'Failed to spawn build script after retry. '
-          'This is likely due to a misconfigured builder definition. '
-          'See the generated script at $scriptLocation to find errors.',
-          e,
+          _log.renderThrowable(
+            'Failed to spawn build script after retry. '
+            'This is likely due to a misconfigured builder definition. '
+            'See the generated script at $scriptLocation to find errors.',
+            e,
+          ),
         );
         messagePort.sendPort.send(ExitCode.config.code);
         exitPort.sendPort.send(null);

build_runner/lib/src/entrypoint/doctor.dart

@@ -71,8 +71,8 @@ class DoctorCommand extends BuildRunnerCommand {
       } on ArgumentError // ignore: avoid_catching_errors
       catch (e) {
         _log.severe(
-          'Failed to parse a `build.yaml` file for ${package.name}',
-          e,
+          'Failed to parse a `build.yaml` file for ${package.name}:'
+          ' ${e.message}',
         );
         return BuildConfig.useDefault(
           package.name,

build_runner/lib/src/entrypoint/run_script.dart

@@ -177,9 +177,11 @@ class RunCommand extends BuildRunnerCommand {
         onExit?.close();
         onError?.close();
         _log.severe(
-          'Unhandled error from script: $scriptName',
-          e[0],
-          StackTrace.fromString(e[1].toString()),
+          _log.renderThrowable(
+            'Unhandled error from script: $scriptName',
+            e[0],
+            StackTrace.fromString(e[1].toString()),
+          ),
         );
         if (!exitCodeCompleter.isCompleted) exitCodeCompleter.complete(1);
       });
@@ -197,9 +199,11 @@ class RunCommand extends BuildRunnerCommand {
       return await exitCodeCompleter.future;
     } on IsolateSpawnException catch (e) {
       _log.severe(
-        'Could not spawn isolate. Ensure that your file is in a valid '
-        'directory (i.e. "bin", "benchmark", "example", "test", "tool").',
-        e,
+        _log.renderThrowable(
+          'Could not spawn isolate. Ensure that your file is in a valid '
+          'directory (i.e. "bin", "benchmark", "example", "test", "tool").',
+          e,
+        ),
       );
       return ExitCode.ioError.code;
     } finally {

build_runner/lib/src/server/server.dart

@@ -423,11 +423,12 @@ class AssetHandler {
         headers[HttpHeaders.contentLengthHeader] = '${body.length}';
       }
       return shelf.Response.ok(body, headers: headers);
-    } catch (e, s) {
+    } catch (e) {
       _log.info(
-        'Error on request ${request.method} ${request.requestedUri}',
-        e,
-        s,
+        _log.renderThrowable(
+          'Error on request ${request.method} ${request.requestedUri}',
+          e,
+        ),
       );
       rethrow;
     }
@@ -757,7 +758,7 @@ shelf.Handler _logRequests(shelf.Handler innerHandler) {
         request.method,
         watch.elapsed,
       );
-      _log.severe(msg, error, stackTrace);
+      _log.severe(_log.renderThrowable(msg, error, stackTrace));
       rethrow;
     }
   };

build_runner/lib/src/watcher/graph_watcher.dart

@@ -56,12 +56,14 @@ class PackageGraphWatcher {
                 StackTrace s,
               ) {
                 _log.severe(
-                  'Error from directory watcher for package:${w.node.name}\n\n'
-                  'If you see this consistently then it is recommended that '
-                  'you enable the polling file watcher with '
-                  '--use-polling-watcher.\n\n',
-                  e,
-                  s,
+                  _log.renderThrowable(
+                    'Error from directory watcher for '
+                    'package:${w.node.name}\n\n'
+                    'If you see this consistently then it is recommended that '
+                    'you enable the polling file watcher with '
+                    '--use-polling-watcher.\n\n',
+                    e,
+                  ),
                 );
               }),
             )

build_runner_core/lib/src/asset/reader_writer.dart

@@ -186,8 +186,8 @@ class ReaderWriter extends AssetReader
       final path = _pathFor(id);
       // Hidden generated files are moved by `assetPathProvider` under the root
       // package folder, and it's allowed to delete them. So for assets in a
-      // different package, check if the path has mapped onto the generated output
-      // path, and if so allow the deleted.
+      // different package, check if the path has mapped onto the generated
+      // output path, and if so allow the deleted.
       var generatedOutputPath = assetPathProvider.pathFor(
         AssetId(rootPackage, generatedOutputDirectory),
       );

build_runner_core/lib/src/asset_graph/graph_loader.dart

@@ -61,9 +61,7 @@ class AssetGraphLoader {
         'Throwing away cached asset graph due to '
         'version mismatch or corrupted asset graph.',
       );
-      await Future.wait([
-        writer.deleteDirectory(_generatedOutputDirectoryId),
-      ]);
+      await Future.wait([writer.deleteDirectory(_generatedOutputDirectoryId)]);
       return null;
     }
   }

build_runner_core/lib/src/generate/build.dart

@@ -276,7 +276,7 @@ class Build {
       },
       (e, st) {
         if (!done.isCompleted) {
-          _log.severe('Unhandled build failure! $e $st', e, st);
+          _log.severe(_log.renderThrowable('Unhandled build failure!', e, st));
           done.complete(BuildResult(BuildStatus.failure, []));
         }
       },

build_runner_core/lib/src/generate/build_definition.dart

@@ -137,8 +137,8 @@ class _Loader {
           _options.packageGraph,
           _environment.reader,
         );
-      } on DuplicateAssetNodeException catch (e, st) {
-        _log.severe('Conflicting outputs', e, st);
+      } on DuplicateAssetNodeException catch (e) {
+        _log.severe(e.toString());
         throw const CannotBuildException();
       }
       buildScriptUpdates = await BuildScriptUpdates.create(

build_runner_core/lib/src/generate/options.dart

@@ -191,17 +191,13 @@ class BuildOptions {
         requiredSourcePaths: [r'lib/$lib$'],
         requiredRootSourcePaths: [r'$package$', r'lib/$lib$'],
       );
-    } on BuildConfigParseException catch (e, s) {
-      _log.severe(
-        '''
+    } on BuildConfigParseException catch (e) {
+      _log.severe('''
 Failed to parse `build.yaml` for ${e.packageName}.
 
 If you believe you have gotten this message in error, especially if using a new
 feature, you may need to run `dart run build_runner clean` and then rebuild.
-''',
-        e.exception,
-        s,
-      );
+''');
       throw const CannotBuildException();
     }