Remove deprecated_warningNotError.

[email protected]

Review-Url: https://codereview.chromium.org/2977903002 .

Author: peter-ahe-google

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart

@@ -1021,6 +1021,53 @@ const MessageCode messageFinalFieldWithoutInitializer = const MessageCode(
     message: r"""A 'final' field must be initialized.""",
     tip: r"""Try adding '= <initializer>'.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(String name)>
+    templateFinalInstanceVariableAlreadyInitialized =
+    const Template<Message Function(String name)>(
+        messageTemplate:
+            r"""'#name' is a final instance variable that has already been initialized.""",
+        withArguments: _withArgumentsFinalInstanceVariableAlreadyInitialized);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(String name)>
+    codeFinalInstanceVariableAlreadyInitialized =
+    const Code<Message Function(String name)>(
+  "FinalInstanceVariableAlreadyInitialized",
+  templateFinalInstanceVariableAlreadyInitialized,
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsFinalInstanceVariableAlreadyInitialized(String name) {
+  return new Message(codeFinalInstanceVariableAlreadyInitialized,
+      message:
+          """'$name' is a final instance variable that has already been initialized.""",
+      arguments: {'name': name});
+}
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(String name)>
+    templateFinalInstanceVariableAlreadyInitializedCause =
+    const Template<Message Function(String name)>(
+        messageTemplate: r"""'#name' was initialized here.""",
+        withArguments:
+            _withArgumentsFinalInstanceVariableAlreadyInitializedCause);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(String name)>
+    codeFinalInstanceVariableAlreadyInitializedCause =
+    const Code<Message Function(String name)>(
+  "FinalInstanceVariableAlreadyInitializedCause",
+  templateFinalInstanceVariableAlreadyInitializedCause,
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsFinalInstanceVariableAlreadyInitializedCause(
+    String name) {
+  return new Message(codeFinalInstanceVariableAlreadyInitializedCause,
+      message: """'$name' was initialized here.""", arguments: {'name': name});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeFunctionTypeDefaultValue = messageFunctionTypeDefaultValue;
 
@@ -2297,6 +2344,14 @@ Message _withArgumentsSupertypeIsTypeVariable(String name) {
       arguments: {'name': name});
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeSwitchCaseFallThrough = messageSwitchCaseFallThrough;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageSwitchCaseFallThrough = const MessageCode(
+    "SwitchCaseFallThrough",
+    message: r"""Switch case may fall through to the next case.""");
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String name)>
     templateThisAccessInFieldInitializer =

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -3012,7 +3012,9 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
     DartType bound = pop();
     if (bound != null) {
       // TODO(ahe): To handle F-bounded types, this needs to be a TypeBuilder.
-      deprecated_warningNotError("Type variable bounds not implemented yet.",
+      warningNotError(
+          fasta.templateInternalProblemUnimplemented
+              .withArguments("bounds on type variables"),
           offsetForToken(extendsOrSuper.next));
     }
     Identifier name = pop();
@@ -3120,8 +3122,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
   }
 
   Expression buildFallThroughError(int charOffset) {
-    deprecated_warningNotError(
-        "Switch case may fall through to next case.", charOffset);
+    warningNotError(fasta.messageSwitchCaseFallThrough, charOffset);
 
     Location location = messages.getLocationFromUri(uri, charOffset);
 
@@ -3182,12 +3183,14 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
       if (builder.isFinal && builder.hasInitializer) {
         // TODO(ahe): If CL 2843733002 is landed, this becomes a compile-time
         // error. Also, this is a compile-time error in strong mode.
-        deprecated_warningNotError(
-            "'$name' is final instance variable that has already been "
-            "initialized.",
+        warningNotError(
+            fasta.templateFinalInstanceVariableAlreadyInitialized
+                .withArguments(name),
             offset);
-        deprecated_warningNotError(
-            "'$name' was initialized here.", builder.charOffset);
+        warningNotError(
+            fasta.templateFinalInstanceVariableAlreadyInitializedCause
+                .withArguments(name),
+            builder.charOffset);
         Builder constructor =
             library.loader.getDuplicatedFieldInitializerError();
         return buildInvalidInitializer(
@@ -3280,10 +3283,6 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
     }
   }
 
-  void deprecated_warningNotError(String message, [int charOffset = -1]) {
-    super.deprecated_warning(message, charOffset);
-  }
-
   void warningNotError(Message message, int charOffset) {
     super.warning(message, charOffset);
   }

pkg/front_end/messages.yaml

@@ -807,3 +807,12 @@ ThisAsIdentifier:
 
 SuperAsIdentifier:
   template: "Expected identifier, but got 'super'."
+
+SwitchCaseFallThrough:
+  template: "Switch case may fall through to the next case."
+
+FinalInstanceVariableAlreadyInitialized:
+  template: "'#name' is a final instance variable that has already been initialized."
+
+FinalInstanceVariableAlreadyInitializedCause:
+  template: "'#name' was initialized here."