Remove deprecated_addError.

[email protected]

Review-Url: https://codereview.chromium.org/2982673002 .

Author: peter-ahe-google

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart

@@ -281,6 +281,24 @@ const MessageCode messageConflictsWithTypeVariableCause = const MessageCode(
     "ConflictsWithTypeVariableCause",
     message: r"""This is the type variable.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeConstConstructorNonFinalField =
+    messageConstConstructorNonFinalField;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageConstConstructorNonFinalField = const MessageCode(
+    "ConstConstructorNonFinalField",
+    message: r"""Constructor is marked 'const' so all fields must be final.""");
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeConstConstructorNonFinalFieldCause =
+    messageConstConstructorNonFinalFieldCause;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageConstConstructorNonFinalFieldCause = const MessageCode(
+    "ConstConstructorNonFinalFieldCause",
+    message: r"""Field isn't final, but constructor is 'const'.""");
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeConstConstructorWithBody = messageConstConstructorWithBody;
 
@@ -2295,6 +2313,32 @@ const MessageCode messageSuperNullAware = const MessageCode("SuperNullAware",
     message: r"""'super' can't be null.""",
     tip: r"""Try replacing '?.' with '.'""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+    Message Function(
+        String
+            name)> templateSuperclassHasNoDefaultConstructor = const Template<
+        Message Function(String name)>(
+    messageTemplate:
+        r"""The superclass, '#name', has no unnamed constructor that takes no arguments.""",
+    withArguments: _withArgumentsSuperclassHasNoDefaultConstructor);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(String name)>
+    codeSuperclassHasNoDefaultConstructor =
+    const Code<Message Function(String name)>(
+  "SuperclassHasNoDefaultConstructor",
+  templateSuperclassHasNoDefaultConstructor,
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsSuperclassHasNoDefaultConstructor(String name) {
+  return new Message(codeSuperclassHasNoDefaultConstructor,
+      message:
+          """The superclass, '$name', has no unnamed constructor that takes no arguments.""",
+      arguments: {'name': name});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String name)> templateSuperclassHasNoGetter =
     const Template<Message Function(String name)>(

pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

@@ -53,7 +53,12 @@ import '../deprecated_problems.dart'
 
 import '../dill/dill_target.dart' show DillTarget;
 
-import '../messages.dart' show LocatedMessage;
+import '../messages.dart'
+    show
+        LocatedMessage,
+        messageConstConstructorNonFinalField,
+        messageConstConstructorNonFinalFieldCause,
+        templateSuperclassHasNoDefaultConstructor;
 
 import '../problems.dart' show unhandled;
 
@@ -117,15 +122,6 @@ class KernelTarget extends TargetImplementation {
     loader = createLoader();
   }
 
-  void deprecated_addError(file, int charOffset, String message) {
-    Uri uri = file is String ? Uri.parse(file) : file;
-    deprecated_InputError error =
-        new deprecated_InputError(uri, charOffset, message);
-    String formatterMessage = error.deprecated_format();
-    print(formatterMessage);
-    errors.add(formatterMessage);
-  }
-
   SourceLoader<Library> createLoader() =>
       new SourceLoader<Library>(fileSystem, this);
 
@@ -556,11 +552,10 @@ class KernelTarget extends TargetImplementation {
           superTarget ??= defaultSuperConstructor(cls);
           Initializer initializer;
           if (superTarget == null) {
-            deprecated_addError(
-                constructor.enclosingClass.fileUri,
-                constructor.fileOffset,
-                "${cls.superclass.name} has no constructor that takes no"
-                " arguments.");
+            builder.addCompileTimeError(
+                templateSuperclassHasNoDefaultConstructor
+                    .withArguments(cls.superclass.name),
+                constructor.fileOffset);
             initializer = new InvalidInitializer();
           } else {
             initializer =
@@ -584,15 +579,11 @@ class KernelTarget extends TargetImplementation {
         }
         fieldInitializers[constructor] = myFieldInitializers;
         if (constructor.isConst && nonFinalFields.isNotEmpty) {
-          deprecated_addError(
-              constructor.enclosingClass.fileUri,
-              constructor.fileOffset,
-              "Constructor is marked 'const' so all fields must be final.");
+          builder.addCompileTimeError(
+              messageConstConstructorNonFinalField, constructor.fileOffset);
           for (Field field in nonFinalFields) {
-            deprecated_addError(
-                constructor.enclosingClass.fileUri,
-                field.fileOffset,
-                "Field isn't final, but constructor is 'const'.");
+            builder.addCompileTimeError(
+                messageConstConstructorNonFinalFieldCause, field.fileOffset);
           }
           nonFinalFields.clear();
         }

pkg/front_end/messages.yaml

@@ -831,3 +831,12 @@ SuperclassHasNoSetter:
 
 SuperclassHasNoMethod:
   template: "Superclass has no method named '#name'."
+
+SuperclassHasNoDefaultConstructor:
+  template: "The superclass, '#name', has no unnamed constructor that takes no arguments."
+
+ConstConstructorNonFinalField:
+  template: "Constructor is marked 'const' so all fields must be final."
+
+ConstConstructorNonFinalFieldCause:
+  template: "Field isn't final, but constructor is 'const'."