Skip to content

Commit deb9cd3

Browse files
kenzieschmollCommit Bot
authored and
Commit Bot
committed
Add missing 'help' option to DevTools server arg parser.
This option existed in the previous impl of devtools server: https://github.com/flutter/devtools/blob/v2.10.0/packages/devtools_server/lib/src/server.dart#L507-L516 Change-Id: Icdc2f1b29e9128531a51fbc471c7b52e761e8f31 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232122 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ben Konyi <[email protected]> Commit-Queue: Kenzie Davisson <[email protected]>
1 parent f6ebb50 commit deb9cd3

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

pkg/dartdev/lib/src/commands/devtools.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ class DevToolsCommand extends DartdevCommand {
1414
DevToolsCommand({
1515
this.customDevToolsPath,
1616
bool verbose = false,
17-
}) : _argParser = DevToolsServer.buildArgParser(verbose: verbose),
17+
}) : _argParser = DevToolsServer.buildArgParser(
18+
verbose: verbose,
19+
includeHelpOption: false,
20+
),
1821
super(
1922
'devtools',
2023
DevToolsServer.commandDescription,

pkg/dds/lib/devtools_server.dart

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,24 @@ class DevToolsServer {
4747
late ClientManager clientManager;
4848
final bool _isChromeOS = File('/dev/.cros_milestone').existsSync();
4949

50-
static ArgParser buildArgParser({bool verbose = false}) {
50+
/// Builds an arg parser for the DevTools server.
51+
///
52+
/// [includeHelpOption] should be set to false if this arg parser will be used
53+
/// in a Command subclass.
54+
static ArgParser buildArgParser({
55+
bool verbose = false,
56+
bool includeHelpOption = true,
57+
}) {
5158
final argParser = ArgParser();
59+
60+
if (includeHelpOption) {
61+
argParser.addFlag(
62+
argHelp,
63+
negatable: false,
64+
abbr: 'h',
65+
help: 'Prints help output.',
66+
);
67+
}
5268
argParser
5369
..addFlag(
5470
argVersion,

0 commit comments

Comments
 (0)