-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.area-intellijTracking issues for the Dart IntelliJ plugin.Tracking issues for the Dart IntelliJ plugin.devexp-analyticstype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Description
The analyzer needs to send the protocol for the new survey data, which the IntelliJ plugin now supports (see JetBrains/intellij-plugins@7295e00).
https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html - changes recorded as version 1.34.0
From Brian on some notes on how to implement:
The support is in SurveyManager
(in sdk/pkg/analysis_server/lib/src/services/user_prompts/survey_manager.dart
). It depends on the AnalysisServer
(specifically LegacyAnalysisServer
in this case) being able to return a non-null value from both userPromptSender and openUriNotificationSender
. I haven't looked at LegacyAnalysisServer to see whether either of these is available.
eliasyishak
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.area-intellijTracking issues for the Dart IntelliJ plugin.Tracking issues for the Dart IntelliJ plugin.devexp-analyticstype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug