Skip to content

Commit ae994a8

Browse files
author
Anna Gringauze
authored
Fix broken debugging caused by missing CallFrame.url (#1559)
* Fix broken debugging caused by missing CallFrame.url * Updated debug extension pubspec, changelog, and version * Emit errors if frame urls are not found * Format changes * Address CR comments
1 parent bd3ab2f commit ae994a8

File tree

12 files changed

+4261
-4288
lines changed

12 files changed

+4261
-4288
lines changed

dwds/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- Update error message on expression evaluation using unloaded libraries.
1717
- Add `screen` field to the `DebuggerReady` event.
1818
- Report `DebuggerReady` events for DevTools embedded into Chrome Devtools.
19+
- Fix missing `CallFrame.url` after update to Chrome 100.
1920

2021
**Breaking changes:**
2122
- `Dwds.start` and `ExpressionCompilerService` now take

dwds/debug_extension/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.28
2+
3+
- Support Chrome 100 updates to the remote debugging protocol.
4+
15
## 1.27
26

37
- Support embedded debugger and inspector in Chrome DevTools for Flutter Web apps.

dwds/debug_extension/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: extension
22
publish_to: none
3-
version: 1.27.0
3+
version: 1.28.0
44
homepage: https://github.com/dart-lang/webdev
55
description: >-
66
A chrome extension for Dart debugging.

dwds/debug_extension/web/background.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,8 +575,6 @@ void _filterAndForwardToBackend(Debuggee source, String method, Object params) {
575575

576576
if (debugSession == null) return;
577577

578-
if (method == 'Debugger.scriptParsed') return;
579-
580578
var event = _extensionEventFor(method, params);
581579

582580
debugSession.socketClient.sink.add(jsonEncode(serializers.serialize(event)));

0 commit comments

Comments
 (0)