Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

Archive this repo? #80

Closed
jsignell opened this issue Feb 8, 2021 · 14 comments · Fixed by #84
Closed

Archive this repo? #80

jsignell opened this issue Feb 8, 2021 · 14 comments · Fixed by #84

Comments

@jsignell
Copy link
Member

jsignell commented Feb 8, 2021

Since the functionality has been moved to xgboost itself. Would now be the appropriate time to archive this repo?

@jrbourbeau
Copy link
Member

@gforsyth
Copy link

gforsyth commented Feb 8, 2021

We've moved our work over to xgboost.dask, so for our purposes, anyway, this repo can be archived.

@jakirkham
Copy link
Member

SGTM. Should we update the README to reflect this?

@jrbourbeau
Copy link
Member

That sounds good. Similar to dask-lightgbm, we might also consider issuing a final release before archiving which adds a warning that the functionality in dask-xgboost has been moved into xgboost and dask-xgboost is no longer maintained

@jakirkham
Copy link
Member

cc @hcho3 @trivialfis @JohnZed (for vis)

@trivialfis
Copy link

Can we wait for xgb 1.4? I would like to get the integrated version feature complete at this version.

@TomAugspurger
Copy link
Member

TomAugspurger commented Feb 8, 2021 via email

@JohnZed
Copy link
Contributor

JohnZed commented Feb 9, 2021

In the near future, I'd be totally onboard with archiving. But I agree with @trivialfis - there are still a few more minor bits coming for xgboost.dask in 1.4 (DART algo comes to mind?), so archiving this project after 1.4 is out would sound most appealing, as then we can clearly say there is no reason to use it for any new code.

@trivialfis
Copy link

Hi, XGBoost 1.4.1 is out and available on pypi. I believe we can safely redirect users to the xgboost.dask module in the future as it's mostly feature-complete now. Thanks for the excellent work everyone! ;-)

@jsignell
Copy link
Member Author

Great! So what's needed is a note on the readme and then for someone to push the "archive button"?

@jrbourbeau
Copy link
Member

Adding a promonant note to the README sounds good. I'll propose we also add a warning which points users to xgboost.dask (similar to what we did with dask-lightgbm) and issue a final release.

@jakirkham
Copy link
Member

There's also some references to Dask-XGBoost in Dask-ML ( dask/dask-ml#844 ). We may want to remove those as well.

@jrbourbeau
Copy link
Member

Just pushed out 0.2.0 which contains deprecation warnings (xref #84). Planning to archive this repo tomorrow morning (in the central time zone)

@jakirkham
Copy link
Member

Thanks James! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants