fixing ups...

Author: AbhishekKumar9984

amazon-redshift-plugin/src/test/java/io/cdap/plugin/amazon/redshift/RedshiftFailedConnectionTest.java

@@ -28,11 +28,11 @@ public class RedshiftFailedConnectionTest extends DBSpecificFailedConnectionTest
   public void test() throws ClassNotFoundException, IOException {
 
     RedshiftConnector connector = new RedshiftConnector(
-            new RedshiftConnectorConfig("username", "password", "jdbc", "", "localhost", "db", 5432));
+      new RedshiftConnectorConfig("username", "password", "jdbc", "", "localhost", "db", 5432));
 
     super.test(JDBC_DRIVER_CLASS_NAME, connector, "Failed to create connection to database via connection string: " +
-            "jdbc:redshift://localhost:5432/db and arguments: " +
-            "{user=username}. Error: ConnectException: Connection refused " +
-            "(Connection refused).");
+      "jdbc:redshift://localhost:5432/db and arguments: " +
+      "{user=username}. Error: ConnectException: Connection refused " +
+      "(Connection refused).");
   }
 }

database-commons/src/main/java/io/cdap/plugin/db/config/AbstractDBSpecificSourceConfig.java

@@ -148,7 +148,7 @@ public void validate(FailureCollector collector) {
       TransactionIsolationLevel.validate(getTransactionIsolationLevel(), collector);
     }
 
-      if (!containsMacro(PROPERTY_IMPORT_QUERY_TYPE)) {
+    if (!containsMacro(PROPERTY_IMPORT_QUERY_TYPE)) {
         ImportQueryType importQueryType = ImportQueryType.fromString(getImportQueryType());
         boolean isImportQuery = importQueryType == ImportQueryType.IMPORT_QUERY;
 
@@ -159,12 +159,11 @@ public void validate(FailureCollector collector) {
         }
       }
 
-
-      if (!hasOneSplit && !containsMacro(IMPORT_QUERY) && !getImportQuery().contains("$CONDITIONS")) {
+    if (!hasOneSplit && !containsMacro(IMPORT_QUERY) && !getImportQuery().contains("$CONDITIONS")) {
       collector.addFailure(String.format(
         "Import Query %s must contain the string '$CONDITIONS'. if Number of Splits is not set to 1.", importQuery),
-                      "Include '$CONDITIONS' in the Import Query")
-              .withConfigProperty(IMPORT_QUERY);
+                           "Include '$CONDITIONS' in the Import Query")
+        .withConfigProperty(IMPORT_QUERY);
     }
 
     if (!hasOneSplit && !containsMacro(SPLIT_BY) && (splitBy == null || splitBy.isEmpty())) {
@@ -206,7 +205,7 @@ public void validateSchema(Schema actualSchema, FailureCollector collector) {
       Schema actualFieldSchema = actualField.getSchema().isNullable() ?
         actualField.getSchema().getNonNullable() : actualField.getSchema();
       Schema expectedFieldSchema = field.getSchema().isNullable() ?
-              field.getSchema().getNonNullable() : field.getSchema();
+        field.getSchema().getNonNullable() : field.getSchema();
 
       validateField(collector, field, actualFieldSchema, expectedFieldSchema);
     }

postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresSchemaReader.java

@@ -95,9 +95,7 @@ public Schema getSchema(String typeName, int columnType, int precision, int scal
       return Schema.of(Schema.Type.STRING);
     }
     // If it is a numeric type without precision then use the Schema of String to avoid any precision loss
-    if (Types.NUMERIC == columnType ||
-            "numeric".equalsIgnoreCase(typeName) ||
-            "decimal".equalsIgnoreCase(typeName)) {
+    if (Types.NUMERIC == columnType) {
       if (precision == 0) {
         LOG.warn(String.format("Field '%s' is a %s type without precision and scale, "
                         + "converting into STRING type to avoid any precision loss.",

postgresql-plugin/src/test/java/io/cdap/plugin/postgres/PostgresFailedConnectionTest.java

@@ -28,11 +28,11 @@ public class PostgresFailedConnectionTest extends DBSpecificFailedConnectionTest
   public void test() throws ClassNotFoundException, IOException {
 
     PostgresConnector connector = new PostgresConnector(
-            new PostgresConnectorConfig("localhost", 5432, "username", "password", "jdbc", ""));
+      new PostgresConnectorConfig("localhost", 5432, "username", "password", "jdbc", ""));
 
     super.test(JDBC_DRIVER_CLASS_NAME, connector, "Failed to create connection to database via connection string: " +
-            "jdbc:postgresql://localhost:5432/null and arguments: " +
-            "{user=username}. Error: ConnectException: Connection refused " +
-            "(Connection refused).");
+      "jdbc:postgresql://localhost:5432/null and arguments: " +
+      "{user=username}. Error: ConnectException: Connection refused " +
+      "(Connection refused).");
   }
 }