Skip to content

Commit e6ea548

Browse files
authored
VER: Release 0.44.1
See release notes.
2 parents a35f21f + 06c0991 commit e6ea548

File tree

6 files changed

+26
-19
lines changed

6 files changed

+26
-19
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## 0.44.1 - 2024-10-29
4+
5+
#### Enhancements
6+
- Improved exception messages emitted by the `Live` client to always include contents of any `ErrorMsg` sent by the gateway
7+
8+
#### Bug fixes
9+
- Fixed an issue where calling `Live.stop` would not close the connection within a reasonable time
10+
311
## 0.44.0 - 2024-10-22
412

513
#### Enhancements

databento/live/protocol.py

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -195,21 +195,20 @@ def connection_lost(self, exc: Exception | None) -> None:
195195
"""
196196
super().connection_lost(exc)
197197
if not self.disconnected.done():
198-
if exc is None:
199-
logger.info("connection closed")
200-
if self._error_msgs:
201-
error_msg = ", ".join(self._error_msgs)
202-
if len(self._error_msgs) > 1:
203-
error_msg = f"The following errors occurred: {error_msg}"
204-
self._error_msgs.clear()
205-
self.disconnected.set_exception(
206-
BentoError(error_msg),
207-
)
208-
else:
209-
self.disconnected.set_result(None)
210-
else:
198+
if self._error_msgs:
199+
error_msg = ", ".join(self._error_msgs)
200+
if len(self._error_msgs) > 1:
201+
error_msg = f"The following errors occurred: {error_msg}"
202+
self._error_msgs.clear()
203+
204+
logger.error("gateway error: %s", exc)
205+
self.disconnected.set_exception(BentoError(error_msg))
206+
elif exc is not None:
211207
logger.error("connection lost: %s", exc)
212208
self.disconnected.set_exception(exc)
209+
else:
210+
logger.info("connection closed")
211+
self.disconnected.set_result(None)
213212

214213
def eof_received(self) -> bool | None:
215214
"""

databento/live/session.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,7 @@ def stop(self) -> None:
440440
return
441441
if self._transport.can_write_eof():
442442
self._transport.write_eof()
443-
else:
444-
self._transport.close()
443+
self._transport.close()
445444

446445
def start(self) -> None:
447446
"""

databento/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.44.0"
1+
__version__ = "0.44.1"

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "databento"
3-
version = "0.44.0"
3+
version = "0.44.1"
44
description = "Official Python client library for Databento"
55
authors = [
66
"Databento <[email protected]>",

tests/test_historical_bento.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,14 +365,15 @@ def test_to_parquet_overwrite(
365365
dbnstore = DBNStore.from_bytes(data=stub_data)
366366
parquet_path = tmp_path / "my_test.parquet"
367367
dbnstore.to_parquet(path=parquet_path)
368-
assert parquet_path.stat().st_size == 9888
368+
parquet_size = parquet_path.stat().st_size
369369

370370
# Act
371371
dbnstore.to_parquet(path=parquet_path)
372372

373373
# Assert
374+
assert parquet_size > 0 # Should be about ~9000 bytes
374375
assert parquet_path.exists()
375-
assert parquet_path.stat().st_size == 9888
376+
assert parquet_path.stat().st_size == parquet_size
376377

377378

378379
def test_to_parquet_exclusive(

0 commit comments

Comments
 (0)