Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yacman tests take too long when they fail #30

Open
nsheff opened this issue Feb 6, 2020 · 1 comment
Open

yacman tests take too long when they fail #30

nsheff opened this issue Feb 6, 2020 · 1 comment
Assignees

Comments

@nsheff
Copy link
Member

nsheff commented Feb 6, 2020

If it passes, pytest only takes a few seconds.

But if it fails, pytest is taking a minute and I have to cancel it. I wonder if it has something to do with the 'wait' function of yacman?

The errors that I'm seeing in these cases are:

        if totaltime >= wait_max:
>               raise RuntimeError("The maximum wait time has been reached and the lock file still exists.")
E               RuntimeError: The maximum wait time has been reached and the lock file still exists.

we need to streamline the tests so that even if they fail, fail quickly.

@nsheff
Copy link
Member Author

nsheff commented Feb 6, 2020

Along similar lines; if the tests fail, then they leave behind lock files, which makes a repeated run of the test fail, even if the underlying cause is complete.

the tests need to clean up after themselves, even if interrupted, so that if run repeatedly they don't cause erroneous repeated failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants