chore: missing linting error (#48)

Author: MarioCadenas

NOTICE.md

@@ -6,6 +6,7 @@ This Software contains code from the following open source projects:
 
 | Name             | Installed version | License | Code                                                 |
 | :--------------- | :---------------- | :----------- | :--------------------------------------------------- |
+| [@ast-grep/napi](https://www.npmjs.com/package/@ast-grep/napi) | 0.37.0 | MIT | https://ast-grep.github.io |
 | [@hookform/resolvers](https://www.npmjs.com/package/@hookform/resolvers) | 5.2.2 | MIT | https://react-hook-form.com |
 | [@opentelemetry/api](https://www.npmjs.com/package/@opentelemetry/api) | 1.9.0 | Apache-2.0 | https://github.com/open-telemetry/opentelemetry-js/tree/main/api |
 | [@opentelemetry/api-logs](https://www.npmjs.com/package/@opentelemetry/api-logs) | 0.208.0 | Apache-2.0 | https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/api-logs |

packages/appkit/bin/appkit-lint.js

@@ -88,7 +88,7 @@ function lintFile(filePath, rules) {
         column: range.start.column + 1,
         rule: rule.id,
         message: rule.message,
-        code: code.length > 80 ? code.slice(0, 77) + "..." : code,
+        code: code.length > 80 ? `${code.slice(0, 77)}...` : code,
       });
     }
   }

tools/build-notice.ts

@@ -1,70 +1,9 @@
 #!/usr/bin/env node
-import { execSync } from "node:child_process";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-type Package = {
-  name: string;
-  versions: string[];
-  paths: string[];
-  license: string;
-  homepage: string;
-};
-
-type PackageJson = {
-  dependencies?: Record<string, string>;
-};
-
-// Packages whose direct dependencies we want to include in NOTICE.md
-const PUBLISHED_PACKAGES = [
-  "packages/appkit",
-  "packages/appkit-ui",
-  "packages/shared",
-];
-
-function getDirectDependencies(): Set<string> {
-  const directDeps = new Set<string>();
-
-  for (const pkgPath of PUBLISHED_PACKAGES) {
-    const pkgJsonPath = join(process.cwd(), pkgPath, "package.json");
-    try {
-      const content = readFileSync(pkgJsonPath, "utf8");
-      const pkgJson: PackageJson = JSON.parse(content);
-
-      if (pkgJson.dependencies) {
-        for (const depName of Object.keys(pkgJson.dependencies)) {
-          if (!pkgJson.dependencies[depName].startsWith("workspace:")) {
-            directDeps.add(depName);
-          }
-        }
-      }
-    } catch (err) {
-      console.error(`Warning: Could not read ${pkgJsonPath}:`, err);
-    }
-  }
-
-  return directDeps;
-}
+import { type Package, getDirectDependencyLicenses } from "./license-utils";
 
 try {
-  const output = execSync("pnpm licenses list --json --production", {
-    encoding: "utf8",
-  });
-  const licenses: Record<string, Package[]> = JSON.parse(output);
-  const directDeps = getDirectDependencies();
-
-  const dependencies: Package[] = [];
-
-  for (const [licenseName, packages] of Object.entries(licenses)) {
-    for (const pkg of packages) {
-      // Only include direct dependencies
-      if (directDeps.has(pkg.name)) {
-        dependencies.push({ ...pkg, license: licenseName });
-      }
-    }
-  }
-
-  main(dependencies);
+  const packages = getDirectDependencyLicenses();
+  main(packages);
 } catch (err) {
   console.error("❌ Error running license check:", err);
   process.exit(1);
@@ -96,7 +35,7 @@ This Software contains code from the following open source projects:
     }
     notice += `| [${dep.name}](https://www.npmjs.com/package/${
       dep.name
-    }) | ${dep.versions.join(", ")} | ${dep.license} | ${dep.homepage} |\n`;
+    }) | ${dep.versions.join(", ")} | ${dep.license} | ${dep.homepage ?? ""} |\n`;
   }
   // eslint-disable-next-line no-console
   console.log(notice);

tools/check-licenses.ts

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { execSync } from "node:child_process";
+import { type Package, getDirectDependencyLicenses } from "./license-utils";
 
 const allowedLicenses = new Set([
   "MIT",
@@ -27,28 +27,18 @@ const disallowedPatterns = [
   /SEE LICEN[CS]E/i,
 ];
 
-type Package = {
-  name: string;
-  versions: string[];
-  paths: string[];
-  license: string;
-};
-
 try {
-  const output = execSync("pnpm licenses list --json", { encoding: "utf8" });
-  const licenses: Record<string, Package[]> = JSON.parse(output);
+  const packages = getDirectDependencyLicenses();
 
-  const violations = [];
+  const violations: Package[] = [];
 
-  for (const [licenseName, packages] of Object.entries(licenses)) {
-    if (allowedLicenses.has(licenseName)) continue;
+  for (const pkg of packages) {
+    if (allowedLicenses.has(pkg.license)) continue;
 
-    const isDisallowed = disallowedPatterns.some((rx) => rx.test(licenseName));
+    const isDisallowed = disallowedPatterns.some((rx) => rx.test(pkg.license));
     if (!isDisallowed) continue;
 
-    for (const pkg of packages) {
-      violations.push({ ...pkg, license: licenseName });
-    }
+    violations.push(pkg);
   }
 
   if (violations.length > 0) {

tools/license-utils.ts

@@ -0,0 +1,70 @@
+import { execSync } from "node:child_process";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+
+export type Package = {
+  name: string;
+  versions: string[];
+  paths: string[];
+  license: string;
+  homepage?: string;
+};
+
+type PackageJson = {
+  dependencies?: Record<string, string>;
+};
+
+// Packages whose direct dependencies we want to include in published artifacts
+export const PUBLISHED_PACKAGES = [
+  "packages/appkit",
+  "packages/appkit-ui",
+  "packages/shared",
+];
+
+export function getDirectDependencies(): Set<string> {
+  const directDeps = new Set<string>();
+
+  for (const pkgPath of PUBLISHED_PACKAGES) {
+    const pkgJsonPath = join(process.cwd(), pkgPath, "package.json");
+    try {
+      const content = readFileSync(pkgJsonPath, "utf8");
+      const pkgJson: PackageJson = JSON.parse(content);
+
+      if (pkgJson.dependencies) {
+        for (const depName of Object.keys(pkgJson.dependencies)) {
+          if (!pkgJson.dependencies[depName].startsWith("workspace:")) {
+            directDeps.add(depName);
+          }
+        }
+      }
+    } catch (err) {
+      console.error(`Warning: Could not read ${pkgJsonPath}:`, err);
+    }
+  }
+
+  return directDeps;
+}
+
+/**
+ * Fetches license data from pnpm and filters to only include direct dependencies
+ * of published packages.
+ */
+export function getDirectDependencyLicenses(): Package[] {
+  const output = execSync("pnpm licenses list --json --production", {
+    encoding: "utf8",
+  });
+  const licenses: Record<string, Package[]> = JSON.parse(output);
+  const directDeps = getDirectDependencies();
+
+  const dependencies: Package[] = [];
+
+  for (const [licenseName, packages] of Object.entries(licenses)) {
+    for (const pkg of packages) {
+      if (directDeps.has(pkg.name)) {
+        dependencies.push({ ...pkg, license: licenseName });
+      }
+    }
+  }
+
+  return dependencies;
+}