Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change self.blocking in dmoe.py from 128 to 64? #114

Open
seanM29 opened this issue May 24, 2024 · 2 comments
Open

Can we change self.blocking in dmoe.py from 128 to 64? #114

seanM29 opened this issue May 24, 2024 · 2 comments

Comments

@seanM29
Copy link

seanM29 commented May 24, 2024

I use megablocks to implement a fine-granded moe, the ffn_hidden_size is divisible by 64, but is not divisible by 128, can we change it to 64? Thanks a lot

@mvpatel2000
Copy link
Contributor

@tgale96 what are the performance implications for block size selection?

For now, to unblock I'd recommend forking or overriding the variable... but I'm not as sure here.

@tgale96
Copy link
Contributor

tgale96 commented May 28, 2024

I recommend using the grouped code path rather than changing the block size. That is untested and likely to result in poor performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants