Skip to content

Commit 3fa391d

Browse files
authored
fix: Revert "fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)" (#16770)
1 parent 184cfda commit 3fa391d

7 files changed

Lines changed: 361 additions & 398 deletions

File tree

metadata-ingestion/src/datahub/ingestion/source/sql/mssql/source.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@
6666
generate_procedure_lineage,
6767
)
6868
from datahub.ingestion.source.usage.usage_common import BaseUsageConfig
69-
from datahub.metadata.schema_classes import (
70-
ForeignKeyConstraintClass,
71-
SchemaFieldClass,
72-
)
7369
from datahub.sql_parsing.sql_parsing_aggregator import SqlParsingAggregator
7470
from datahub.utilities.file_backed_collections import FileBackedList
7571
from datahub.utilities.perf_timer import PerfTimer
@@ -550,23 +546,6 @@ def _get_columns(
550546
column["comment"] = description
551547
return columns
552548

553-
def get_schema_fields(
554-
self,
555-
dataset_name: str,
556-
columns: List[dict],
557-
inspector: Inspector,
558-
pk_constraints: Optional[dict] = None,
559-
partition_keys: Optional[List[str]] = None,
560-
tags: Optional[Dict[str, List[str]]] = None,
561-
) -> List[SchemaFieldClass]:
562-
schema_fields = super().get_schema_fields(
563-
dataset_name, columns, inspector, pk_constraints, partition_keys, tags
564-
)
565-
if self.config.convert_urns_to_lowercase:
566-
for field in schema_fields:
567-
field.fieldPath = field.fieldPath.lower()
568-
return schema_fields
569-
570549
def get_database_level_workunits(
571550
self,
572551
inspector: Inspector,
@@ -1265,22 +1244,6 @@ def construct_flow_workunits(
12651244
aspect=data_flow.as_container_aspect,
12661245
).as_workunit()
12671246

1268-
def get_foreign_key_metadata(
1269-
self,
1270-
dataset_urn: str,
1271-
schema: str,
1272-
fk_dict: Dict[str, Any],
1273-
inspector: Inspector,
1274-
) -> ForeignKeyConstraintClass:
1275-
if self.config.convert_urns_to_lowercase:
1276-
fk_dict["constrained_columns"] = [
1277-
f.lower() for f in fk_dict["constrained_columns"]
1278-
]
1279-
fk_dict["referred_columns"] = [
1280-
f.lower() for f in fk_dict["referred_columns"]
1281-
]
1282-
return super().get_foreign_key_metadata(dataset_urn, schema, fk_dict, inspector)
1283-
12841247
def get_inspectors(self) -> Iterable[Inspector]:
12851248
# This method can be overridden in the case that you want to dynamically
12861249
# run on multiple databases.

metadata-ingestion/tests/integration/sql_server/golden_files/golden_mces_mssql_ephemeral_pattern.json

Lines changed: 47 additions & 47 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)