From fca2562cc09b328447a08db199cf072b484bf3c4 Mon Sep 17 00:00:00 2001 From: Chrissy LeMaire Date: Fri, 25 Oct 2024 17:24:35 +0200 Subject: [PATCH] fix param checker - we will be checking for whatif and confirm --- .aider/prompts/conventions.md | 3 +-- .aider/prompts/template.md | 6 +++--- tests/Add-DbaAgDatabase.Tests.ps1 | 3 +-- tests/Add-DbaAgListener.Tests.ps1 | 3 +-- tests/Add-DbaAgReplica.Tests.ps1 | 3 +-- tests/Add-DbaComputerCertificate.Tests.ps1 | 3 +-- tests/Add-DbaDbMirrorMonitor.Tests.ps1 | 3 +-- tests/Add-DbaDbRoleMember.Tests.ps1 | 3 +-- tests/Add-DbaExtendedProperty.Tests.ps1 | 3 +-- tests/Add-DbaPfDataCollectorCounter.Tests.ps1 | 3 +-- tests/Add-DbaRegServer.Tests.ps1 | 3 +-- tests/Add-DbaRegServerGroup.Tests.ps1 | 3 +-- tests/Add-DbaReplArticle.Tests.ps1 | 3 +-- tests/Add-DbaServerRoleMember.Tests.ps1 | 3 +-- tests/Backup-DbaComputerCertificate.Tests.ps1 | 3 +-- tests/Backup-DbaDbCertificate.Tests.ps1 | 3 +-- tests/Backup-DbaDbMasterKey.Tests.ps1 | 3 +-- tests/Backup-DbaServiceMasterKey.Tests.ps1 | 3 +-- tests/Clear-DbaConnectionPool.Tests.ps1 | 3 +-- tests/Clear-DbaLatchStatistics.Tests.ps1 | 3 +-- tests/Clear-DbaPlanCache.Tests.ps1 | 3 +-- tests/Clear-DbaWaitStatistics.Tests.ps1 | 3 +-- tests/Convert-DbaLsn.Tests.ps1 | 3 +-- tests/Convert-DbaMaskingValue.Tests.ps1 | 3 +-- tests/ConvertTo-DbaTimeline.Tests.ps1 | 3 +-- tests/ConvertTo-DbaXESession.Tests.ps1 | 3 +-- tests/Copy-DbaAgentAlert.Tests.ps1 | 3 +-- tests/Copy-DbaAgentJob.Tests.ps1 | 3 +-- tests/Copy-DbaAgentJobCategory.Tests.ps1 | 3 +-- tests/Copy-DbaAgentOperator.Tests.ps1 | 3 +-- 30 files changed, 32 insertions(+), 61 deletions(-) diff --git a/.aider/prompts/conventions.md b/.aider/prompts/conventions.md index ba8c178bfe..6da1ca8b70 100644 --- a/.aider/prompts/conventions.md +++ b/.aider/prompts/conventions.md @@ -141,8 +141,7 @@ Describe "Get-DbaDatabase" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/.aider/prompts/template.md b/.aider/prompts/template.md index 3c0e4623fb..e631c6f98e 100644 --- a/.aider/prompts/template.md +++ b/.aider/prompts/template.md @@ -2,10 +2,10 @@ You are an AI assistant created by Anthropic to help migrate Pester tests for the **dbatools PowerShell module** from version 4 to version 5. Analyze and update the file `/workspace/tests/--CMDNAME--.Tests.ps1` according to the instructions in conventions.md. -Required parameters for this command: ---PARMZ-- - Command name: --CMDNAME-- +Parameters for this command: +--PARMZ-- + Before responding, verify that your answer adheres to the specified coding and migration guidelines. \ No newline at end of file diff --git a/tests/Add-DbaAgDatabase.Tests.ps1 b/tests/Add-DbaAgDatabase.Tests.ps1 index 436d4a0736..8b6f41fb8c 100644 --- a/tests/Add-DbaAgDatabase.Tests.ps1 +++ b/tests/Add-DbaAgDatabase.Tests.ps1 @@ -29,8 +29,7 @@ Describe "Add-DbaAgDatabase" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaAgListener.Tests.ps1 b/tests/Add-DbaAgListener.Tests.ps1 index 83a5cad186..74bd7d1782 100644 --- a/tests/Add-DbaAgListener.Tests.ps1 +++ b/tests/Add-DbaAgListener.Tests.ps1 @@ -29,8 +29,7 @@ Describe "Add-DbaAgListener" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaAgReplica.Tests.ps1 b/tests/Add-DbaAgReplica.Tests.ps1 index 4a2c5cadf6..7c6036e904 100644 --- a/tests/Add-DbaAgReplica.Tests.ps1 +++ b/tests/Add-DbaAgReplica.Tests.ps1 @@ -37,8 +37,7 @@ Describe "Add-DbaAgReplica" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaComputerCertificate.Tests.ps1 b/tests/Add-DbaComputerCertificate.Tests.ps1 index 3c9d3a0b1d..87f77b9a56 100644 --- a/tests/Add-DbaComputerCertificate.Tests.ps1 +++ b/tests/Add-DbaComputerCertificate.Tests.ps1 @@ -26,8 +26,7 @@ Describe "Add-DbaComputerCertificate" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaDbMirrorMonitor.Tests.ps1 b/tests/Add-DbaDbMirrorMonitor.Tests.ps1 index 26f1f1c3b5..236d8604b3 100644 --- a/tests/Add-DbaDbMirrorMonitor.Tests.ps1 +++ b/tests/Add-DbaDbMirrorMonitor.Tests.ps1 @@ -20,8 +20,7 @@ Describe "Add-DbaDbMirrorMonitor" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaDbRoleMember.Tests.ps1 b/tests/Add-DbaDbRoleMember.Tests.ps1 index 30b9e77bc8..19a5c13b97 100644 --- a/tests/Add-DbaDbRoleMember.Tests.ps1 +++ b/tests/Add-DbaDbRoleMember.Tests.ps1 @@ -24,8 +24,7 @@ Describe "Add-DbaDbRoleMember" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaExtendedProperty.Tests.ps1 b/tests/Add-DbaExtendedProperty.Tests.ps1 index 6dddcfbbd2..3d88ea7c63 100644 --- a/tests/Add-DbaExtendedProperty.Tests.ps1 +++ b/tests/Add-DbaExtendedProperty.Tests.ps1 @@ -24,8 +24,7 @@ Describe "Add-DbaExtendedProperty" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 b/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 index e9a1eeab4d..e7a488c7d1 100644 --- a/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 +++ b/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 @@ -24,8 +24,7 @@ Describe "Add-DbaPfDataCollectorCounter" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaRegServer.Tests.ps1 b/tests/Add-DbaRegServer.Tests.ps1 index 0b292b3340..66cd73a4de 100644 --- a/tests/Add-DbaRegServer.Tests.ps1 +++ b/tests/Add-DbaRegServer.Tests.ps1 @@ -30,8 +30,7 @@ Describe "Add-DbaRegServer" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaRegServerGroup.Tests.ps1 b/tests/Add-DbaRegServerGroup.Tests.ps1 index 4987cd28c2..8fb64dc42c 100644 --- a/tests/Add-DbaRegServerGroup.Tests.ps1 +++ b/tests/Add-DbaRegServerGroup.Tests.ps1 @@ -24,8 +24,7 @@ Describe "Add-DbaRegServerGroup" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaReplArticle.Tests.ps1 b/tests/Add-DbaReplArticle.Tests.ps1 index 8088f9e516..12e3113879 100644 --- a/tests/Add-DbaReplArticle.Tests.ps1 +++ b/tests/Add-DbaReplArticle.Tests.ps1 @@ -28,8 +28,7 @@ Describe "Add-DbaReplArticle" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Add-DbaServerRoleMember.Tests.ps1 b/tests/Add-DbaServerRoleMember.Tests.ps1 index ad095cb7a8..d7eb56bb95 100644 --- a/tests/Add-DbaServerRoleMember.Tests.ps1 +++ b/tests/Add-DbaServerRoleMember.Tests.ps1 @@ -24,8 +24,7 @@ Describe "Add-DbaServerRoleMember" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Backup-DbaComputerCertificate.Tests.ps1 b/tests/Backup-DbaComputerCertificate.Tests.ps1 index b810b7643a..2e9b3e2d70 100644 --- a/tests/Backup-DbaComputerCertificate.Tests.ps1 +++ b/tests/Backup-DbaComputerCertificate.Tests.ps1 @@ -23,8 +23,7 @@ Describe "Backup-DbaComputerCertificate" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Backup-DbaDbCertificate.Tests.ps1 b/tests/Backup-DbaDbCertificate.Tests.ps1 index f185d3fae3..e5ad28cb0c 100644 --- a/tests/Backup-DbaDbCertificate.Tests.ps1 +++ b/tests/Backup-DbaDbCertificate.Tests.ps1 @@ -28,8 +28,7 @@ Describe "Backup-DbaDbCertificate" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Backup-DbaDbMasterKey.Tests.ps1 b/tests/Backup-DbaDbMasterKey.Tests.ps1 index 726ea4abba..4c0a726072 100644 --- a/tests/Backup-DbaDbMasterKey.Tests.ps1 +++ b/tests/Backup-DbaDbMasterKey.Tests.ps1 @@ -28,8 +28,7 @@ Describe "Backup-DbaDbMasterKey" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Backup-DbaServiceMasterKey.Tests.ps1 b/tests/Backup-DbaServiceMasterKey.Tests.ps1 index 1d36c8b026..e1ed28f688 100644 --- a/tests/Backup-DbaServiceMasterKey.Tests.ps1 +++ b/tests/Backup-DbaServiceMasterKey.Tests.ps1 @@ -23,8 +23,7 @@ Describe "Backup-DbaServiceMasterKey" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Clear-DbaConnectionPool.Tests.ps1 b/tests/Clear-DbaConnectionPool.Tests.ps1 index 7d734fe919..96720d9975 100644 --- a/tests/Clear-DbaConnectionPool.Tests.ps1 +++ b/tests/Clear-DbaConnectionPool.Tests.ps1 @@ -20,8 +20,7 @@ Describe "Clear-DbaConnectionPool" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Clear-DbaLatchStatistics.Tests.ps1 b/tests/Clear-DbaLatchStatistics.Tests.ps1 index 2acb9cf86f..c9698d3ba3 100644 --- a/tests/Clear-DbaLatchStatistics.Tests.ps1 +++ b/tests/Clear-DbaLatchStatistics.Tests.ps1 @@ -20,8 +20,7 @@ Describe "Clear-DbaLatchStatistics" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Clear-DbaPlanCache.Tests.ps1 b/tests/Clear-DbaPlanCache.Tests.ps1 index fbdd3030c9..79b3dc9767 100644 --- a/tests/Clear-DbaPlanCache.Tests.ps1 +++ b/tests/Clear-DbaPlanCache.Tests.ps1 @@ -22,8 +22,7 @@ Describe "Clear-DbaPlanCache" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Clear-DbaWaitStatistics.Tests.ps1 b/tests/Clear-DbaWaitStatistics.Tests.ps1 index 405751bcc1..726f5d83cb 100644 --- a/tests/Clear-DbaWaitStatistics.Tests.ps1 +++ b/tests/Clear-DbaWaitStatistics.Tests.ps1 @@ -20,8 +20,7 @@ Describe "Clear-DbaWaitStatistics" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Convert-DbaLsn.Tests.ps1 b/tests/Convert-DbaLsn.Tests.ps1 index 87369bfef1..510baaf9d8 100644 --- a/tests/Convert-DbaLsn.Tests.ps1 +++ b/tests/Convert-DbaLsn.Tests.ps1 @@ -19,8 +19,7 @@ Describe "Convert-DbaLSN" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } diff --git a/tests/Convert-DbaMaskingValue.Tests.ps1 b/tests/Convert-DbaMaskingValue.Tests.ps1 index 12d5fb9c17..fc1a709dfc 100644 --- a/tests/Convert-DbaMaskingValue.Tests.ps1 +++ b/tests/Convert-DbaMaskingValue.Tests.ps1 @@ -21,8 +21,7 @@ Describe "Convert-DbaMaskingValue" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/ConvertTo-DbaTimeline.Tests.ps1 b/tests/ConvertTo-DbaTimeline.Tests.ps1 index e3f7a1872a..1344452a3e 100644 --- a/tests/ConvertTo-DbaTimeline.Tests.ps1 +++ b/tests/ConvertTo-DbaTimeline.Tests.ps1 @@ -20,8 +20,7 @@ Describe "ConvertTo-DbaTimeline" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/ConvertTo-DbaXESession.Tests.ps1 b/tests/ConvertTo-DbaXESession.Tests.ps1 index d70d6f3743..6af58b6037 100644 --- a/tests/ConvertTo-DbaXESession.Tests.ps1 +++ b/tests/ConvertTo-DbaXESession.Tests.ps1 @@ -21,8 +21,7 @@ Describe "ConvertTo-DbaXESession" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Copy-DbaAgentAlert.Tests.ps1 b/tests/Copy-DbaAgentAlert.Tests.ps1 index 68ae79f484..690329053d 100644 --- a/tests/Copy-DbaAgentAlert.Tests.ps1 +++ b/tests/Copy-DbaAgentAlert.Tests.ps1 @@ -26,8 +26,7 @@ Describe "Copy-DbaAgentAlert" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } } diff --git a/tests/Copy-DbaAgentJob.Tests.ps1 b/tests/Copy-DbaAgentJob.Tests.ps1 index 62a43bbcab..b5d7566685 100644 --- a/tests/Copy-DbaAgentJob.Tests.ps1 +++ b/tests/Copy-DbaAgentJob.Tests.ps1 @@ -39,8 +39,7 @@ Describe "Copy-DbaAgentJob" -Tag "IntegrationTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } diff --git a/tests/Copy-DbaAgentJobCategory.Tests.ps1 b/tests/Copy-DbaAgentJobCategory.Tests.ps1 index 61a135d93b..565692bd17 100644 --- a/tests/Copy-DbaAgentJobCategory.Tests.ps1 +++ b/tests/Copy-DbaAgentJobCategory.Tests.ps1 @@ -34,8 +34,7 @@ Describe "Copy-DbaAgentJobCategory" -Tag "IntegrationTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } diff --git a/tests/Copy-DbaAgentOperator.Tests.ps1 b/tests/Copy-DbaAgentOperator.Tests.ps1 index 9cf6327ee3..8dd8e3b292 100644 --- a/tests/Copy-DbaAgentOperator.Tests.ps1 +++ b/tests/Copy-DbaAgentOperator.Tests.ps1 @@ -25,8 +25,7 @@ Describe "Copy-DbaAgentOperator" -Tag "UnitTests" { } It "Should have exactly the number of expected parameters" { - $actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" } - Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty + Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty } } }