From 118dd8c7aa1aca0ef0a0bd68adcfd51aaddd786a Mon Sep 17 00:00:00 2001 From: 0x7FFFFFFFFFFFFFFF <39968+0x7FFFFFFFFFFFFFFF@users.noreply.github.com> Date: Sun, 7 Jan 2024 23:00:30 +0800 Subject: [PATCH 1/2] Update Grant-DbaAgPermission.ps1 The original description is a little bit confusing: Endpoint will modify the DatabaseMirror endpoint type. --- public/Grant-DbaAgPermission.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/Grant-DbaAgPermission.ps1 b/public/Grant-DbaAgPermission.ps1 index ab53904f38..5c92b0e4dc 100644 --- a/public/Grant-DbaAgPermission.ps1 +++ b/public/Grant-DbaAgPermission.ps1 @@ -23,7 +23,7 @@ function Grant-DbaAgPermission { Only modify specific availability groups. .PARAMETER Type - Specify type: Endpoint or AvailabilityGroup. Endpoint will modify the DatabaseMirror endpoint type. + Specifies the type of object to which permissions will be granted. Acceptable values are "Endpoint" or "AvailabilityGroup". If "Endpoint" is specified, permissions will be granted to the Database Mirroring endpoint. .PARAMETER Permission Grants one or more permissions: @@ -215,4 +215,4 @@ function Grant-DbaAgPermission { } } } -} \ No newline at end of file +} From 21069f8468235abb639d25d877e484a9ac015d84 Mon Sep 17 00:00:00 2001 From: 0x7FFFFFFFFFFFFFFF <39968+0x7FFFFFFFFFFFFFFF@users.noreply.github.com> Date: Sun, 7 Jan 2024 16:12:56 -0800 Subject: [PATCH 2/2] Update public/Grant-DbaAgPermission.ps1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks for the suggestion. To me, the original phrase, 'The Endpoint will modify the DatabaseMirror endpoint type,' sounds like some DatabaseMirror endpoint type is being modified. It's in fact the DatabaseMirror endpoint type endpoint that is being modified. But I'm not a native English speaker😂 Co-authored-by: Shawn Melton <11204251+wsmelton@users.noreply.github.com> --- public/Grant-DbaAgPermission.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/Grant-DbaAgPermission.ps1 b/public/Grant-DbaAgPermission.ps1 index 5c92b0e4dc..2b753f1675 100644 --- a/public/Grant-DbaAgPermission.ps1 +++ b/public/Grant-DbaAgPermission.ps1 @@ -23,7 +23,7 @@ function Grant-DbaAgPermission { Only modify specific availability groups. .PARAMETER Type - Specifies the type of object to which permissions will be granted. Acceptable values are "Endpoint" or "AvailabilityGroup". If "Endpoint" is specified, permissions will be granted to the Database Mirroring endpoint. + Specify the object type to grant the provided Permission. Values accepted are Endpoint and/or AvailabilityGroup. Endpoint type will update the DatabaseMirroring object type found on the instance. .PARAMETER Permission Grants one or more permissions: