Skip to content

Segmentation fault (core dumped) #128

Answered by davidfrantz
Antguz asked this question in Q&A
Discussion options

You must be logged in to vote

Hi @Antguz, I found and fixed the issue.

In a 2D for-loop in the multi-parameter regression-based resolution merging (RES_MERGE = REGRESSION), both indices were running to the same N...

    for (i=0; i<ny; i++){
    for (j=0; j<ny; j++){

should have been:

    for (i=0; i<ny; i++){
    for (j=0; j<nx; j++){

Strange enough, this method is implemented in FORCE since day 1, but nobody complained yet.
Doesn`t seem a very popular option ;)

Nevertheless, this is fixed now with https://github.com/davidfrantz/force/releases/tag/v3.7.3-fix, and the results look good on my end.
I also noticed that this method was not multi-threaded yet. It is now :)

Thanks for bringing his to my attention.

Cheers,

Replies: 2 comments 12 replies

Comment options

You must be logged in to vote
11 replies
@Antguz
Comment options

@davidfrantz
Comment options

@ernstste
Comment options

@Antguz
Comment options

@ernstste
Comment options

Comment options

You must be logged in to vote
1 reply
@Antguz
Comment options

Answer selected by davidfrantz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
bug Something isn't working
3 participants