Skip to content

Commit d2ab529

Browse files
ani-sinhastsquad
authored andcommitted
docs/devel: remind developers to run CI container pipeline when updating images
When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there are no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha <[email protected]> Reviewed-by: Daniel P. Berrangé <[email protected]> Message-Id: <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]>
1 parent dc389ce commit d2ab529

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

docs/devel/testing.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project:
485485
`CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
486486
page on how to trigger gitlab CI pipelines on your change.
487487

488+
* Please also trigger gitlab container generation pipelines on your change
489+
for as many OS distros as practical to make sure that there are no
490+
obvious breakages when adding the new pre-requisite. Please see
491+
`CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
492+
page on how to trigger gitlab CI pipelines on your change.
493+
488494
For enterprise distros that default to old, end-of-life versions of the
489495
Python runtime, QEMU uses a separate set of mappings that work with more
490496
recent versions. These can be found in ``tests/lcitool/mappings.yml``.

0 commit comments

Comments
 (0)