Skip to content

Commit aa0495a

Browse files
committed
update deps and merge mysql2
Signed-off-by: Tobias Gurtzick <[email protected]>
2 parents 29f75c9 + 79ccece commit aa0495a

File tree

6 files changed

+360
-157
lines changed

6 files changed

+360
-157
lines changed

.eslintrc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
{
22
"extends": "standard",
3+
"parserOptions": {
4+
"ecmaVersion": 2019
5+
},
36
"rules": {
47
"semi": ["error", "always"],
58
"no-unused-vars": "warn",
6-
"quotes": ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": true }]
9+
"quotes": [
10+
"error",
11+
"single",
12+
{ "avoidEscape": true, "allowTemplateLiterals": true }
13+
]
714
}
815
}

index.js

Lines changed: 56 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
var util = require('util');
2-
var moment = require('moment');
3-
var mysql = require('mysql');
4-
var Base = require('db-migrate-base');
5-
var Promise = require('bluebird');
6-
var log;
7-
var type;
1+
const util = require('util');
2+
const moment = require('moment');
3+
const mysql = require('mysql2');
4+
const Base = require('db-migrate-base');
5+
const Promise = require('bluebird');
6+
let log;
7+
let type;
88

9-
var internals = {};
9+
let internals = {};
1010

11-
var MysqlDriver = Base.extend({
11+
const MysqlDriver = Base.extend({
1212
init: function (connection) {
1313
this._escapeDDL = '`';
1414
this._escapeString = "'";
@@ -17,7 +17,7 @@ var MysqlDriver = Base.extend({
1717
},
1818

1919
startMigration: function (cb) {
20-
var self = this;
20+
const self = this;
2121

2222
if (!internals.notransactions) {
2323
return this.runSql('SET AUTOCOMMIT=0;')
@@ -35,7 +35,7 @@ var MysqlDriver = Base.extend({
3535
},
3636

3737
mapDataType: function (spec) {
38-
var len;
38+
let len;
3939
switch (spec.type) {
4040
case type.TEXT:
4141
len = parseInt(spec.length, 10) || 1000;
@@ -72,9 +72,9 @@ var MysqlDriver = Base.extend({
7272
},
7373

7474
createColumnDef: function (name, spec, options, tableName) {
75-
var escapedName = util.format('`%s`', name);
76-
var t = this.mapDataType(spec);
77-
var len;
75+
const escapedName = util.format('`%s`', name);
76+
const t = this.mapDataType(spec);
77+
let len;
7878
if (spec.type === type.DECIMAL) {
7979
if (spec.precision && spec.scale) {
8080
len = '(' + spec.precision + ',' + spec.scale + ')';
@@ -85,7 +85,7 @@ var MysqlDriver = Base.extend({
8585
len = '(255)';
8686
}
8787
}
88-
var constraint = this.createColumnConstraint(
88+
const constraint = this.createColumnConstraint(
8989
spec,
9090
options,
9191
tableName,
@@ -98,8 +98,8 @@ var MysqlDriver = Base.extend({
9898
},
9999

100100
createColumnConstraint: function (spec, options, tableName, columnName) {
101-
var constraint = [];
102-
var cb;
101+
const constraint = [];
102+
let cb;
103103

104104
if (spec.unsigned) {
105105
constraint.push('UNSIGNED');
@@ -159,7 +159,11 @@ var MysqlDriver = Base.extend({
159159
},
160160

161161
renameTable: function (tableName, newTableName, callback) {
162-
var sql = util.format('RENAME TABLE `%s` TO `%s`', tableName, newTableName);
162+
const sql = util.format(
163+
'RENAME TABLE `%s` TO `%s`',
164+
tableName,
165+
newTableName
166+
);
163167
return this.runSql(sql).nodeify(callback);
164168
},
165169

@@ -190,8 +194,8 @@ var MysqlDriver = Base.extend({
190194
},
191195

192196
createDatabase: function (dbName, options, callback) {
193-
var spec = '';
194-
var ifNotExists = '';
197+
const spec = '';
198+
let ifNotExists = '';
195199

196200
if (typeof options === 'function') callback = options;
197201
else {
@@ -215,7 +219,7 @@ var MysqlDriver = Base.extend({
215219
},
216220

217221
dropDatabase: function (dbName, options, callback) {
218-
var ifExists = '';
222+
let ifExists = '';
219223

220224
if (typeof options === 'function') callback = options;
221225
else {
@@ -229,7 +233,7 @@ var MysqlDriver = Base.extend({
229233
},
230234

231235
removeColumn: function (tableName, columnName, callback) {
232-
var sql = util.format(
236+
const sql = util.format(
233237
'ALTER TABLE `%s` DROP COLUMN `%s`',
234238
tableName,
235239
columnName
@@ -248,10 +252,10 @@ var MysqlDriver = Base.extend({
248252
columns = [columns];
249253
}
250254

251-
var columnsList = [];
252-
for (var columnIndex in columns) {
253-
var column = columns[columnIndex];
254-
var columnSpec = '';
255+
const columnsList = [];
256+
for (const columnIndex in columns) {
257+
const column = columns[columnIndex];
258+
let columnSpec = '';
255259

256260
if (typeof column === 'object' && column.name) {
257261
columnSpec = util.format(
@@ -266,7 +270,7 @@ var MysqlDriver = Base.extend({
266270
columnsList.push(columnSpec);
267271
}
268272

269-
var sql = util.format(
273+
const sql = util.format(
270274
'ALTER TABLE `%s` ADD %s INDEX `%s` (%s)',
271275
tableName,
272276
unique ? 'UNIQUE ' : '',
@@ -297,23 +301,23 @@ var MysqlDriver = Base.extend({
297301
return Promise.reject(err);
298302
}
299303

300-
var sql = util.format('DROP INDEX `%s` ON `%s`', indexName, tableName);
304+
const sql = util.format('DROP INDEX `%s` ON `%s`', indexName, tableName);
301305

302306
return this.runSql(sql).nodeify(callback);
303307
},
304308

305309
renameColumn: function (tableName, oldColumnName, newColumnName, callback) {
306-
var self = this;
307-
var columnTypeSql = util.format(
310+
const self = this;
311+
const columnTypeSql = util.format(
308312
"SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '%s' AND COLUMN_NAME = '%s'",
309313
tableName,
310314
oldColumnName
311315
);
312316

313317
return this.runSql(columnTypeSql)
314318
.then(function (result) {
315-
var columnType = result[0].COLUMN_TYPE;
316-
var alterSql = util.format(
319+
const columnType = result[0].COLUMN_TYPE;
320+
const alterSql = util.format(
317321
'ALTER TABLE `%s` CHANGE `%s` `%s` %s',
318322
tableName,
319323
oldColumnName,
@@ -327,15 +331,15 @@ var MysqlDriver = Base.extend({
327331
},
328332

329333
changeColumn: function (tableName, columnName, columnSpec, callback) {
330-
var constraint = this.createColumnDef(columnName, columnSpec);
331-
var sql = util.format(
334+
const constraint = this.createColumnDef(columnName, columnSpec);
335+
const sql = util.format(
332336
'ALTER TABLE `%s` CHANGE COLUMN `%s` %s',
333337
tableName,
334338
columnName,
335339
constraint.constraints
336340
);
337341

338-
var exec = function () {
342+
const exec = function () {
339343
return this.runSql(sql).then(function () {
340344
if (constraint.foreignKey) return constraint.foreignKey();
341345
else return Promise.resolve();
@@ -352,7 +356,7 @@ var MysqlDriver = Base.extend({
352356
},
353357

354358
addMigrationRecord: function (name, callback) {
355-
var formattedDate = moment(new Date()).format('YYYY-MM-DD HH:mm:ss');
359+
const formattedDate = moment(new Date()).format('YYYY-MM-DD HH:mm:ss');
356360
this.runSql(
357361
'INSERT INTO `' +
358362
internals.migrationTable +
@@ -363,7 +367,7 @@ var MysqlDriver = Base.extend({
363367
},
364368

365369
addSeedRecord: function (name, callback) {
366-
var formattedDate = moment(new Date()).format('YYYY-MM-DD HH:mm:ss');
370+
const formattedDate = moment(new Date()).format('YYYY-MM-DD HH:mm:ss');
367371
this.runSql(
368372
'INSERT INTO `' +
369373
internals.seedTable +
@@ -385,11 +389,11 @@ var MysqlDriver = Base.extend({
385389
callback = rules;
386390
rules = {};
387391
}
388-
var columns = Object.keys(fieldMapping);
389-
var referencedColumns = columns.map(function (key) {
392+
const columns = Object.keys(fieldMapping);
393+
const referencedColumns = columns.map(function (key) {
390394
return fieldMapping[key];
391395
});
392-
var sql = util.format(
396+
const sql = util.format(
393397
'ALTER TABLE `%s` ADD CONSTRAINT `%s` FOREIGN KEY (%s) REFERENCES `%s` (%s) ON DELETE %s ON UPDATE %s',
394398
tableName,
395399
keyName,
@@ -404,7 +408,7 @@ var MysqlDriver = Base.extend({
404408
},
405409

406410
removeForeignKey: function (tableName, keyName, options, callback) {
407-
var sql = util.format(
411+
let sql = util.format(
408412
'ALTER TABLE `%s` DROP FOREIGN KEY `%s`',
409413
tableName,
410414
keyName
@@ -433,10 +437,10 @@ var MysqlDriver = Base.extend({
433437
},
434438

435439
runSql: function () {
436-
var self = this;
437-
var args = this._makeParamArgs(arguments);
440+
const self = this;
441+
const args = this._makeParamArgs(arguments);
438442

439-
var callback = args.pop();
443+
const callback = args.pop();
440444
log.sql.apply(null, arguments);
441445
if (internals.dryRun) {
442446
return Promise.resolve().nodeify(callback);
@@ -452,9 +456,9 @@ var MysqlDriver = Base.extend({
452456
},
453457

454458
_makeParamArgs: function (args) {
455-
var params = Array.prototype.slice.call(args);
456-
var sql = params.shift();
457-
var callback =
459+
let params = Array.prototype.slice.call(args);
460+
const sql = params.shift();
461+
const callback =
458462
typeof params[params.length - 1] === 'function' ? params.pop() : null;
459463

460464
if (params.length > 0 && Array.isArray(params[0])) {
@@ -464,7 +468,7 @@ var MysqlDriver = Base.extend({
464468
},
465469

466470
all: function () {
467-
var args = this._makeParamArgs(arguments);
471+
const args = this._makeParamArgs(arguments);
468472

469473
log.sql.apply(null, arguments);
470474

@@ -474,7 +478,7 @@ var MysqlDriver = Base.extend({
474478
close: function (callback) {
475479
return new Promise(
476480
function (resolve, reject) {
477-
var cb = function (err, data) {
481+
const cb = function (err, data) {
478482
return err ? reject(err) : resolve(data);
479483
};
480484

@@ -491,7 +495,7 @@ function dummy () {
491495
}
492496

493497
exports.connect = function (config, intern, callback) {
494-
var db;
498+
let db;
495499

496500
internals = intern;
497501
log = internals.mod.log;
@@ -500,9 +504,9 @@ exports.connect = function (config, intern, callback) {
500504
internals.interfaces.SeederInterface._makeParamArgs = dummy;
501505

502506
if (typeof mysql.createConnection === 'undefined') {
503-
db = config.db || new mysql.createClient(config);
507+
db = config.db || mysql.createClient(config);
504508
} else {
505-
db = config.db || new mysql.createConnection(config);
509+
db = config.db || mysql.createConnection(config);
506510
}
507511

508512
db.connect(function (err) {

0 commit comments

Comments
 (0)