[Android Bootcamp] Project 2: NYT News - Ready for Review

[dbautist]

My app is complete, please review. /cc @codepathreview @codepath

[codepathreview]

👍 Good job getting all required and many optional stories done. Great work this week also after the excellent submission last week. A few notes after checking out the code:

• Great work on organising source code.
• Really nice and clean UI
• Good use of heterogeneous layouts in recycler view
• Nice to see you used action bar for searching
• Good job on getting the Share functionality working
• Great job implementing DialogFragment for filters.
• Good job checking for network availability
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Great job using staggered grid view for polishing the app UI.
• Good job on making settings Parcelable using Parceler instead of Serializable(benefits)
• Excellent job using ButterKnife, it makes the code much cleaner.
• General comment: clean and modularised code, great job on that

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.