Merge pull request #1380 from dbcli/RW/enable-bugbear-rule-B015-pointless-comparison

Enable lint rule B015: pointless comparison

Author: rolandwalker

pyproject.toml

@@ -66,7 +66,6 @@ select = ['A', 'B', 'I', 'E', 'W', 'F', 'C4', 'PIE', 'TID']
 ignore = [
     'B005',   # Multi-character strip()
     'B006',   # TODO: Mutable data structures for argument defaults
-    'B015',   # TODO: Pointless comparison
     'E401',   # Multiple imports on one line
     'E402',   # Module level import not at top of file
     'PIE808', # range() starting with 0

test/test_special_iocommands.py

@@ -51,9 +51,8 @@ def test_editor_command():
 
     os.environ["EDITOR"] = "true"
     os.environ["VISUAL"] = "true"
-    # Set the editor to Notepad on Windows
     if os.name != "nt":
-        mycli.packages.special.open_external_editor(sql=r"select 1") == "select 1"
+        assert mycli.packages.special.open_external_editor(sql=r"select 1") == ('select 1', None)
     else:
         pytest.skip("Skipping on Windows platform.")