Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DamageWithOnKillEffectAction to not use Runnable #519

Open
wang429 opened this issue May 23, 2020 · 0 comments
Open

Refactor DamageWithOnKillEffectAction to not use Runnable #519

wang429 opened this issue May 23, 2020 · 0 comments
Assignees
@wang429

Comments

@wang429
Copy link
Collaborator

wang429 commented May 23, 2020

To me at least, Runnable implies some level of threading, which isn't what the action handles. As such, I propose using Supplier<Void> instead.

This can be done after #512 is merged.
@wang429 wang429 self-assigned this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wang429 wang429

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wang429