Added command line flag parsing via cli package #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks! You seem to have accidentally committed the executive binary for lsp. Could you clean that up? |
Removed binary from branch
|
Done, and put in .gitignore for future builds. |
|
@dborzov Do you need anything else? |
|
@siddharthist sorry for the delay. PR looks great and is sorely needed! Thanks! A couple of things:
Incorrect Usage.
NAME:
lsp - lsp is like ls command but more human-friendly
USAGE:
lsp [global options] [arguments...]
VERSION:
dev
AUTHOR(S):
dborzov
GLOBAL OPTIONS:
-d, --directories Only show directories
-h, --human Show human readable file sizes
-l, --long Long form, show more details
-s, --size Show and order by size
-t, --time Show and order by modification time
-p, --pyramid Align files to the left side
--version, -v print the version
-------------------------------------------------------------------------------------------------
fff333 dir(empty one)
.travis.yml Text File
.gitignore Text File
arguments.go Text File
arguments_test.go Text File
CONTRIBUTING.md Text File
fmt.go Text File
fileinfo.go Text File
filelist.go Text File
investigate.go Text File
LICENSE Text File
main.go Text File
paths.go Text File
README.md Text File
sort.go Text File
tty_win.go Text File
traverse.go Text File
trie.go Text File
tty_unix.go Text File
utils.go Text File
-------------------------------------------------------------------------------------------------
lsp "/k/src/github.com/dborzov/lsp", 21 files, 1 directories
git repo (remote at [email protected]:dborzov/lsp.git)It should be only the help message.
I can add any of those changes myself if you prefer. |
|
@dborzov I'd be happy to add some of them, I've just been a little busy. Feel free to add any yourself as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #7
Fixes #12, fixes #1.
This is a great example of why you should use external libraries instead of falling trap to NIH.