feat(go): handle SCRIPT-type queries returning results (cherry-picked from upstream) - #14
Merged
Merged
Conversation
) Also, patch the SDK to expose the true reason if we fail to get an Arrow iterator. Patch for the SDK: lidavidm/google-cloud-go@3e66704 Related issue: dbt-labs/dbt#16081 Unlike the forked driver, we catch SCRIPT queries that don't return results and continue substituting in an empty result set. --------- Co-authored-by: Mandukhai Alimaa <114253933+Mandukhai-Alimaa@users.noreply.github.com> (cherry picked from commit b995c04)
serramatutu
had a problem deploying
to
BigQuery CI
August 31, 2026 13:26 — with 
GitHub Actions
Error
GitHub Actions
Error
serramatutu
had a problem deploying
to
BigQuery CI
August 31, 2026 13:26 — with
GitHub Actions
Error
GitHub Actions
Error
serramatutu
had a problem deploying
to
BigQuery CI
August 31, 2026 13:26 — with
GitHub Actions
Failure
GitHub Actions
Failure
serramatutu
had a problem deploying
to
BigQuery CI
August 31, 2026 13:26 — with
GitHub Actions
Failure
GitHub Actions
Failure
serramatutu
changed the title
serramatutu
changed the title
why |
VersusFacit
reviewed
Sep 1, 2026
VersusFacit
left a comment
VersusFacit
left a comment
There was a problem hiding this comment.
lgtm but I'd like to know why we have this divergence from the upstream
VersusFacit
approved these changes
Sep 1, 2026
Author
Harry's rebase was done before this patch landed upstream. In fact, I reported the bug to them and they fixed it lol |
|
Yes, thanks for reporting it to us! |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picking from upstream:
Also, patch the SDK to expose the true reason if we fail to get
an Arrow iterator.
Patch for the SDK:
lidavidm/google-cloud-go@3e66704
Related issue:
dbt-labs/dbt#16081
Unlike the forked driver, we catch SCRIPT queries that don't
return results and continue substituting in an empty result set.
Co-authored-by: Mandukhai Alimaa 114253933+Mandukhai-Alimaa@users.noreply.github.com
(cherry picked from commit b995c04)