Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build check workflow #1069

Closed
mikealfare opened this issue Jul 18, 2024 · 0 comments · Fixed by #1105
Closed

Update the build check workflow #1069

mikealfare opened this issue Jul 18, 2024 · 0 comments · Fixed by #1105

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Jul 18, 2024

Current Behavior

We install the wheel, check that the package is installed, then immediately install the sdist, and check that the package is installed again.

Expected Behavior

We should be validating the packages in isolated environments. This arose from the setuptools / packaging issue for dbt-core<1.4, but it's something we should do for current versions as well. See dbt-labs/dbt-core#10465 for the analogous dbt-core issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant