Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-677] [Feature] Add a BaseClass to the ConnectionWrapper #829

Closed
3 tasks done
Fokko opened this issue Jul 7, 2023 · 0 comments · Fixed by #828
Closed
3 tasks done

[ADAP-677] [Feature] Add a BaseClass to the ConnectionWrapper #829

Fokko opened this issue Jul 7, 2023 · 0 comments · Fixed by #828
Labels
enhancement New feature or request

Comments

@Fokko
Copy link
Contributor

Fokko commented Jul 7, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Before adding #814 I think it would be nice to add a base class above the wrapper to make sure that we don't break any methods.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@Fokko Fokko added enhancement New feature or request triage labels Jul 7, 2023
@github-actions github-actions bot changed the title [Feature] Add a BaseClass to the ConnectionWrapper [ADAP-677] [Feature] Add a BaseClass to the ConnectionWrapper Jul 7, 2023
@jtcohen6 jtcohen6 removed the triage label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants