Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-3596] [Feature] Migrate to msgspec #1683

Open
3 tasks done
plypaul opened this issue Mar 6, 2025 · 0 comments
Open
3 tasks done

[SL-3596] [Feature] Migrate to msgspec #1683

plypaul opened this issue Mar 6, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request Medium priority Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@plypaul
Copy link
Contributor

plypaul commented Mar 6, 2025

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Python-native dataclasses are widely used in the codebase, and they are not the most efficient in a few areas (e.g. object initialization and hash computation). Initial benchmarks on msgspec are promising, and once larger performance improvement changes are in place, we should try out msgspec. Another advantage of msgspec is that it can replace some custom methods / classes for serialization.

Describe alternatives you've considered

Pydantic

Who will this benefit?

All users.

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-3596

@plypaul plypaul added enhancement New feature or request triage Tasks that need to be triaged labels Mar 6, 2025
@plypaul plypaul self-assigned this Mar 6, 2025
@plypaul plypaul changed the title [Feature] Migrate to msgspec [SL-3596] [Feature] Migrate to msgspec Mar 6, 2025
@plypaul plypaul added the Medium priority Created by Linear-GitHub Sync label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium priority Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant