Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are sorted in Normalizer, but Labelmap are not #193

Closed
vsaase opened this issue Mar 11, 2021 · 2 comments
Closed

Images are sorted in Normalizer, but Labelmap are not #193

vsaase opened this issue Mar 11, 2021 · 2 comments

Comments

@vsaase
Copy link
Contributor

vsaase commented Mar 11, 2021

return fillSegmentation(segmentation, inputLabelmaps3D, userOptions);

Here the assumption is that after creating the Segmentation object, the references are still orderd like the images and the labelmaps. However, Normalizer sorts the images by physical position, resulting in mixing of the labelmaps in the stack.

See also the discussion in issue #144

@vsaase
Copy link
Contributor Author

vsaase commented Mar 11, 2021

ok, sorry, seems to be sorted out in #154

@vsaase vsaase closed this as completed Mar 11, 2021
@vsaase
Copy link
Contributor Author

vsaase commented Mar 11, 2021

I think the problem is really in the fillSegmentation method that assumes same ordering as in segmentation object. The inputLabelmaps3D object does not have enough information, as this depends on the ordering of the images in the viewer. A solution would be to provide a map that maps from the labelmap indices to the referenced SOPInstanceUIDs, and the let fillSegmentation sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant