Skip to content

Commit 1f5287f

Browse files
dweinholzeKatchkovktrrdkdependabot-preview[bot]denbicloud
authoredSep 8, 2020
Staging (#1938)
* updated liniting * fix(Application):termination for vo always possible * update changelog * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Tests):updated tests * fix(application): add ? to some application * * fix(Projects):filtering for vo and facilitymanager fixed * fix(Tests):updated tests * fix(Projects):filtering for vo and facilitymanager fixed * fix(VmOverview):fixed redirect and tests * Staging (#1926) * prepare update * build(deps-dev): bump less-loader from 6.2.0 to 7.0.0 Bumps [less-loader](https://github.com/webpack-contrib/less-loader) from 6.2.0 to 7.0.0. - [Release notes](https://github.com/webpack-contrib/less-loader/releases) - [Changelog](https://github.com/webpack-contrib/less-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/less-loader@v6.2.0...v7.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump sass-loader from 10.0.0 to 10.0.1 Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.0 to 10.0.1. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v10.0.0...v10.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump jspdf from 2.0.0 to 2.1.0 Bumps [jspdf](https://github.com/MrRio/jsPDF) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/MrRio/jsPDF/releases) - [Changelog](https://github.com/MrRio/jsPDF/blob/master/RELEASE.md) - [Commits](https://github.com/MrRio/jsPDF/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump uglify-js from 3.10.2 to 3.10.3 Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.10.2 to 3.10.3. - [Release notes](https://github.com/mishoo/UglifyJS/releases) - [Commits](mishoo/UglifyJS@v3.10.2...v3.10.3) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump chromedriver from 84.0.1 to 85.0.0 Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 84.0.1 to 85.0.0. - [Release notes](https://github.com/giggio/node-chromedriver/releases) - [Commits](https://github.com/giggio/node-chromedriver/commits) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump ngx-bootstrap from 5.6.1 to 6.1.0 Bumps [ngx-bootstrap](https://github.com/valor-software/ngx-bootstrap) from 5.6.1 to 6.1.0. - [Release notes](https://github.com/valor-software/ngx-bootstrap/releases) - [Changelog](https://github.com/valor-software/ngx-bootstrap/blob/development/CHANGELOG.md) - [Commits](valor-software/ngx-bootstrap@v5.6.1...v6.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump html-webpack-plugin from 4.3.0 to 4.4.1 Bumps [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin) from 4.3.0 to 4.4.1. - [Release notes](https://github.com/jantimon/html-webpack-plugin/releases) - [Changelog](https://github.com/jantimon/html-webpack-plugin/blob/master/CHANGELOG.md) - [Commits](jantimon/html-webpack-plugin@v4.3.0...v4.4.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump @types/jasmine from 3.5.13 to 3.5.14 Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 3.5.13 to 3.5.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine) Signed-off-by: dependabot-preview[bot] <[email protected]> * fix(Links):fixed links * fix(Linting):blacked code * fixed lintin * feat(Docker):change building staging instead of dev branch * dev to staging in build action * build(deps-dev): bump file-loader from 6.0.0 to 6.1.0 Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v6.0.0...v6.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * fix(VmOverview):vm per site debounce time to 1s (#1896) Co-authored-by: denbicloud <[email protected]> * fix(Layout):fixed the state badge for the applications (#1897) * fix(Layout):fixed the state badge for the applications * removed badge states Co-authored-by: denbicloud <[email protected]> * fix(VmOverview):vm per site debounce time to 1s (#1896) Co-authored-by: denbicloud <[email protected]> * fix(Layout):fixed the state badge for the applications (#1897) * fix(Layout):fixed the state badge for the applications * removed badge states Co-authored-by: denbicloud <[email protected]> * fix(credits): init and mod req credits fixed * fix(Linting):blacked code * refactor(Application):improved detail overview (#1900) * refactor(Application):improved detail overview * fix(Linting):blacked code * fixed flavors for modificaiton Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: denbicloud <[email protected]> * fix(credits): init and mod req credits fixed * fix(Linting):blacked code * refactor(Application):improved detail overview (#1900) * refactor(Application):improved detail overview * fix(Linting):blacked code * fixed flavors for modificaiton Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: denbicloud <[email protected]> * fix(Application):round credits to two decimals * fixed credits user * removed logs * credits loop starts when applicaiton is loaded * fixed relaoding overview with different project * fix(Test):updated some ids for testing * fix(Credits):if no perun id doesnt request current credits (#1911) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Tests):updated tests * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Credits):if no perun id doesnt request current credits (#1911) (#1912) * fix(Tests):updated tests * fix(application): add ? to some application * * fix(Projects):filtering for vo and facilitymanager fixed * fix(Tests):updated tests * fix(Projects):filtering for vo and facilitymanager fixed * fix(VmOverview):fixed redirect and tests Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: denbicloud <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ekatchko <[email protected]> Co-authored-by: eKatchko <[email protected]> * fix(Modifications):modifications loading again in overview Co-authored-by: eKatchko <[email protected]> Co-authored-by: ekatchko <[email protected]> Co-authored-by: vktrrdk <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: denbicloud <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent f5183cb commit 1f5287f

13 files changed

+109
-45
lines changed
 

‎CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## (2020-07-10)
2+
3+
4+
#### Bug Fixes
5+
6+
* **lifetime:** mod req lifetime string adjusted. try catch exception. ([97ddb284](97ddb284))
7+
* **mod-req:** submit disabled if no edam ([f96ad419](f96ad419))
8+
19
## (2020-06-18)
210

311

‎e2e/page_objects/login.po.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class LoginPage {
3232
}
3333

3434
static async useGoogle(email: string, psw: string): Promise<any> {
35-
await element(by.linkText('Sign in with Google')).click()
35+
await Util.clickElementByLinkText('Sign in with Google')
3636
// Input Email
3737
await Util.waitForPage('accounts.google.com/o/oauth2/');
3838
await Util.sendTextToElementById('identifierId', email, false);

‎e2e/protractor.conf.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ exports.config = {
3030
allScriptsTimeout: 11000,
3131
specs: [
3232
'tests/simple_vm_application_test.ts',
33+
3334
'tests/simple_vm_approval_test.ts',
3435
'tests/member_test.ts',
3536
'tests/simple_vm_modification_test.ts',
@@ -38,7 +39,7 @@ exports.config = {
3839
'tests/cloud_application_test.ts',
3940
'tests/cloud_application_approval_test.ts',
4041
'tests/cloud_application_modification_test.ts',
41-
'tests/cloud_modification_approval_test.ts',
42+
'tests/cloud_modification_approval_test.ts',*/
4243
'tests/virtual_machine_tests.ts',
4344
'tests/terminate_all_pt.ts'
4445
],

‎e2e/util.ts

+17
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,23 @@ export class Util {
114114
return await elem.sendKeys(text);
115115
}
116116

117+
static async clickElementByLinkText(text: string): Promise<void> {
118+
await Util.waitForElementToBeClickableByLinkText(text)
119+
console.log('Clicking element with text:')
120+
121+
return await element(by.linkText('Sign in with Google')).click();
122+
123+
}
124+
125+
static async waitForElementToBeClickableByLinkText(text: string, timeout: number = this.timeout): Promise<boolean> {
126+
const until_: ProtractorExpectedConditions = protractor.ExpectedConditions;
127+
128+
console.log(`Waiting until element is clickable with text: ${text}`);
129+
const elem: ElementFinder = element(by.linkText(text));
130+
131+
return await browser.driver.wait(until_.elementToBeClickable(elem), timeout, 'Element taking too long to be clickable');
132+
}
133+
117134
static async sendTextToElementById(id: string, text: string, show_output: boolean = true): Promise<void> {
118135
await this.waitForVisibilityOfElementById(id);
119136
if (show_output) {

‎src/app/applications/application-detail/application-detail.component.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<li class="nav-item"><a class="nav-link" id="information_tab" [ngClass]="{'active': INFORMATION_TAB_ACTIVE }"
66
(click)="setTab(INFORMATION_TAB)">Informations</a></li>
77
<li class="nav-item"><a class="nav-link" id="resource_tab" [ngClass]="{'active': RESOURCE_TAB_ACTIVE }"
8-
(click)="setTab(RESOURCE_TAB)">Resources</a></li>
8+
(click)="setTab(RESOURCE_TAB)">Current Resources</a></li>
9+
910
<li class="nav-item"><a class="nav-link" id="modification_tab" *ngIf="(application | hasstatusinlist:Application_States.MODIFICATION_REQUESTED)
1011
|| (application | hasstatusinlist: Application_States.WAIT_FOR_CONFIRMATION_MODIFICATION)"
1112
[ngClass]="{'active': MODIFICATION_TAB_ACTIVE }"

‎src/app/applications/application-detail/lifetime-extension-detail/lifetime-extension-detail.component.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
</td>
66

77
<td>
8-
{{application?.project_lifetime_request.user.username}}
8+
{{application?.project_lifetime_request?.user?.username}}
9+
910
( {{application?.project_lifetime_request?.user?.email}}
1011
| {{application?.project_lifetime_request?.user?.elixir_id}}
1112
)

‎src/app/applications/applications.component.html

+8-8
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@
327327
<div class="btn-group">
328328

329329

330-
<button [id]="'modification_approval_' + application.project_application_shortname"
331-
*ngIf="(application | hasstatusinlist:Application_States.MODIFICATION_REQUESTED) || application?.project_modification_request"
330+
<button [id]="'modification_approval_' + application?.project_application_shortname"
331+
*ngIf="(application | hasstatusinlist:Application_States.MODIFICATION_REQUESTED) && application?.project_modification_request"
332332
style="margin: auto 2.5px"
333333
(click)="this.resetNotificationModal(); this.approveModificationRequest(application);
334334
this.notificationModal.show();"
@@ -339,7 +339,7 @@
339339
</button>
340340

341341
<button
342-
*ngIf="(application | hasstatusinlist:Application_States.MODIFICATION_REQUESTED) "
342+
*ngIf="(application | hasstatusinlist:Application_States.MODIFICATION_REQUESTED) && application?.project_modification_request "
343343
type="button"
344344
class="btn btn-danger"
345345
style="margin: auto 2.5px"
@@ -473,8 +473,8 @@
473473

474474
<td>
475475
<div class="btn-group">
476-
<button [id]="'extension_approval_' + application.project_application_shortname"
477-
*ngIf="(application | hasstatusinlist:Application_States.LIFETIME_EXTENSION_REQUESTED) || application?.project_lifetime_request"
476+
<button [id]="'extension_approval_' + application?.project_application_shortname"
477+
*ngIf="(application | hasstatusinlist:Application_States.LIFETIME_EXTENSION_REQUESTED) && application?.project_lifetime_request"
478478
style="margin: auto 2.5px"
479479
(click)="resetNotificationModal();
480480
approveLifetimeExtension(application);
@@ -485,7 +485,7 @@
485485
<span class="applicationActionsButton">Approve Extension</span>
486486
</button>
487487
<button
488-
*ngIf="(application | hasstatusinlist:Application_States.LIFETIME_EXTENSION_REQUESTED) || application?.project_lifetime_request"
488+
*ngIf="(application | hasstatusinlist:Application_States.LIFETIME_EXTENSION_REQUESTED) && application?.project_lifetime_request"
489489
type="button"
490490
class="btn btn-danger"
491491
style="margin: auto 2.5px"
@@ -622,7 +622,7 @@
622622
<td>
623623
<div class="btn-group">
624624

625-
<button [id]="'credit_extension_approval_' + application.project_application_shortname"
625+
<button [id]="'credit_extension_approval_' + application?.project_application_shortname"
626626
*ngIf="(application | hasstatusinlist:Application_States.CREDITS_EXTENSION_REQUESTED) "
627627
style="margin: auto 2.5px"
628628
(click)="this.resetNotificationModal(); this.approveCreditExtension(application);
@@ -633,7 +633,7 @@
633633
<span class="applicationActionsButton">Approve Credits</span>
634634
</button>
635635

636-
<button [id]="'credit_extension_decline_' + application.project_application_shortname"
636+
<button [id]="'credit_extension_decline_' + application?.project_application_shortname"
637637
*ngIf="(application | hasstatusinlist:Application_States.CREDITS_EXTENSION_REQUESTED) "
638638
(click)="this.resetNotificationModal(); this.declineCreditExtension(application);
639639
notificationModal.show();"

‎src/app/applications/applications.component.ts

+39-12
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ export class ApplicationsComponent extends ApplicationBaseClassComponent impleme
102102
this.getApplicationHistory();
103103
this.getComputeCenters();
104104
this.applicationsservice.getExtensionRequestsCounter().subscribe((result: any): void => {
105-
this.numberOfCreditRequests = result['credits_extension_requests_vo'];
106-
this.numberOfExtensionRequests = result['lifetime_extension_requests_vo'];
107-
this.numberOfModificationRequests = result['modification_requests_vo'];
105+
this.numberOfCreditRequests = result['credits_extension_requests_all'];
106+
this.numberOfExtensionRequests = result['lifetime_extension_requests_all'];
107+
this.numberOfModificationRequests = result['modification_requests_all'];
108108
this.numberOfProjectApplications = result['applications_submitted_vo'];
109109
});
110110
} else {
@@ -161,12 +161,19 @@ export class ApplicationsComponent extends ApplicationBaseClassComponent impleme
161161
this.applicationsservice.approveAdditionalLifetime(application.project_application_id)
162162
.subscribe((res: any): void => {
163163
if (application.project_application_openstack_project) {
164+
application.project_application_status = []
165+
this.getApplication(application)
166+
167+
164168
this.updateNotificationModal('Success', 'The request has been sent to the facility manager.', true, 'success');
165169
} else {
166170
this.updateNotificationModal('Success', 'The project has been extended!', true, 'success');
167171
}
168-
this.all_applications.splice(this.all_applications.indexOf(application), 1);
169-
this.numberOfExtensionRequests--;
172+
if (!application.project_application_openstack_project) {
173+
this.numberOfExtensionRequests--;
174+
this.all_applications.splice(this.all_applications.indexOf(application), 1);
175+
176+
}
170177
},
171178
(err: any): void => {
172179
console.log('error', err.status);
@@ -194,9 +201,18 @@ export class ApplicationsComponent extends ApplicationBaseClassComponent impleme
194201

195202
this.applicationsservice.approveModificationRequest(application.project_application_id)
196203
.subscribe((res: any): void => {
204+
197205
this.updateNotificationModal('Success', 'The resource modification request was approved!', true, 'success');
198-
this.all_applications.splice(this.all_applications.indexOf(application), 1);
199-
this.numberOfModificationRequests--;
206+
if (!application.project_application_openstack_project) {
207+
208+
this.numberOfModificationRequests--;
209+
this.all_applications.splice(this.all_applications.indexOf(application), 1);
210+
211+
} else {
212+
application.project_application_status = []
213+
214+
this.getApplication(application)
215+
}
200216
},
201217
(err: any): void => {
202218
console.log('error', err.status);
@@ -221,9 +237,18 @@ export class ApplicationsComponent extends ApplicationBaseClassComponent impleme
221237
approveCreditExtension(application: Application): void {
222238
this.applicationsservice.approveAdditionalCreditsRequest(application.project_application_id)
223239
.subscribe((res: any): void => {
240+
224241
this.updateNotificationModal('Success', 'The credit extension request was approved!', true, 'success');
225-
this.all_applications.splice(this.all_applications.indexOf(application), 1);
226-
this.numberOfCreditRequests--;
242+
if (!application.project_application_openstack_project) {
243+
244+
this.numberOfCreditRequests--;
245+
this.all_applications.splice(this.all_applications.indexOf(application), 1);
246+
247+
} else {
248+
application.project_application_status = []
249+
250+
this.getApplication(application)
251+
}
227252
},
228253
(err: any): void => {
229254
console.log('error', err.status);
@@ -424,15 +449,17 @@ export class ApplicationsComponent extends ApplicationBaseClassComponent impleme
424449
this.groupservice.createGroupOpenStack(
425450
application.project_application_id, compute_center)
426451
.subscribe((result: { [key: string]: string }): void => {
452+
427453
if (result['Error']) {
428454
this.updateNotificationModal('Failed', result['Error'], true, 'danger');
429455

430456
} else {
457+
application.project_application_status = []
458+
431459
this.updateNotificationModal('Success', 'The new project was created', true, 'success');
432-
this.all_applications.splice(this.all_applications.indexOf(application), 1);
433-
this.numberOfProjectApplications--;
460+
this.getApplication(application);
461+
434462
}
435-
this.getApplication(application);
436463
},
437464
(): void => {
438465
this.updateNotificationModal('Failed', 'Project could not be created!', true, 'danger');

‎src/app/facility_manager/facility.application.component.ts

+9-1
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,15 @@ export class FacilityApplicationComponent extends ApplicationBaseClassComponent
256256
this.allApplicationsToCheck = [];
257257
this.all_application_modifications = [];
258258
this.applications_history = [];
259+
this.facilityService.getExtensionRequestsCounterFacility(this.selectedFacility['FacilityId'])
260+
.subscribe((res: any): void => {
261+
this.numberOfCreditRequests = res['credits_extension_requests'];
262+
this.numberOfExtensionRequests = res['lifetime_extension_requests'];
263+
this.numberOfModificationRequests = res['modification_requests'];
264+
this.numberOfProjectApplications = res['applications_submitted'];
265+
});
266+
this.changeTabState(TabStates.SUBMITTED);
267+
this.isLoaded = true;
259268
// this.getFullApplications(this.selectedFacility ['FacilityId']);
260269
this.getAllApplicationsHistory(this.selectedFacility ['FacilityId']);
261270

@@ -335,7 +344,6 @@ export class FacilityApplicationComponent extends ApplicationBaseClassComponent
335344
this.changeTabState(TabStates.SUBMITTED);
336345
this.isLoaded = true;
337346

338-
this.facilityService.getFacilityResources(this.selectedFacility['FacilityId']).subscribe();
339347
this.getApplicationStatus();
340348
// this.getFullApplications(this.selectedFacility ['FacilityId']);
341349
this.getAllApplicationsHistory(this.selectedFacility ['FacilityId']);

‎src/app/layouts/full-layout.component.html

+10-10
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@
9494
<li class="nav-item" *ngFor="let application of project_enumeration">
9595

9696
<a *ngIf="!navbar_minimized" class="nav-link" routerLinkActive="active" [id]="application?.project_name"
97-
[routerLink]="['/project-management/' + application.application_id]">
97+
[routerLink]="['/project-management/' + application?.application_id]">
9898
<div class="row" style="margin:0px;">
99-
<span *ngIf="application.is_open_stack"
99+
<span *ngIf="application?.is_open_stack"
100100
style="float:left; font-size: 20px; margin-right: 10px;"
101101
class="project-openstack_plain_white_redbg"
102102
data-toggle="tooltip"
@@ -116,11 +116,11 @@
116116
<span class="path5"></span>
117117
</span>
118118
<span style="display: inline-block;width: 65%;overflow: hidden;text-overflow: ellipsis;">
119-
{{application.project_name}}
119+
{{application?.project_name}}
120120
</span>
121121
</div>
122122

123-
<div class="row justify-content-center" id="status_row_{{application.application_id}}" style="margin: 2px;">
123+
<div class="row justify-content-center" id="status_row_{{application?.application_id}}" style="margin: 2px;">
124124
<span class="badge badge-success status-badge" data-toggle="tooltip"
125125
data-placement="right" title="This project was initially approved within the last 2 weeks."
126126
*ngIf="(application | hasstatusinlist:Application_States.APPROVED_LAST_2_WEEKS)">
@@ -169,10 +169,10 @@
169169

170170
</a>
171171

172-
<a *ngIf="navbar_minimized && !application.is_open_stack" class="nav-link" routerLinkActive="active"
172+
<a *ngIf="navbar_minimized && !application?.is_open_stack" class="nav-link" routerLinkActive="active"
173173
style="text-align: center;"
174-
[routerLink]="['/project-management/' + application.application_id]" data-toggle="tooltip"
175-
data-placement="right" [title]="application.project_name">
174+
[routerLink]="['/project-management/' + application?.application_id]" data-toggle="tooltip"
175+
data-placement="right" [title]="application?.project_name">
176176
<span class="project-simpleVM_Logo_bluebg"
177177
style="color: #FFF; position:relative; left:8px; font-size: 20px">
178178
<span class="path1"></span>
@@ -183,10 +183,10 @@
183183
</span>
184184
</a>
185185

186-
<a *ngIf="navbar_minimized && application.is_open_stack" class="nav-link" routerLinkActive="active"
186+
<a *ngIf="navbar_minimized && application?.is_open_stack" class="nav-link" routerLinkActive="active"
187187
style="text-align: center;"
188-
[routerLink]="['/project-management/' + application.application_id]" data-toggle="tooltip"
189-
data-placement="right" [title]="application.project_name">
188+
[routerLink]="['/project-management/' + application?.application_id]" data-toggle="tooltip"
189+
data-placement="right" [title]="application?.project_name">
190190
<span class="project-openstack_plain_white_redbg"
191191
style="color: #FFF; position:relative; left:8px; font-size: 20px">
192192
<span class="path1"></span>

‎src/app/projectmanagement/overview.component.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -605,8 +605,9 @@ <h4 class="modal-title">Applications for {{project?.Name}}</h4>
605605
</thead>
606606
<tbody *ngFor=" let application of project?.ProjectMemberApplications">
607607

608-
<td>{{application.Name}}</td>
609-
<td>{{application.DateCreated}}</td>
608+
<td>{{application?.Name}}</td>
609+
<td>{{application?.DateCreated}}</td>
610+
610611
<td>
611612
<button
612613
(click)="approveMemberApplication(project?.Id,application.Id,application.Name); "

‎src/app/virtualmachines/clusters/clusteroverview/clusterOverview.component.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -111,19 +111,19 @@
111111
<a *ngIf="!show_connection_infO"
112112
class="font-weight-bold font-xs btn-block text-muted btn btn-outline-secondary"
113113
[id]="'showHowToConnectButton_'+cluster?.cluster_id"
114-
(click)="show_connection_infO=true; " href="#" onClick="return false;">
114+
(click)="show_connection_infO=true; " onClick="return false;">
115115
How to connect ...</a>
116116

117117
<a *ngIf="show_connection_infO" class="font-weight-bold font-xs btn-block btn btn-secondary"
118118
[id]="'hideHowToConnectButton_'+cluster?.cluster_id"
119-
(click)="show_connection_infO=false; " href="#" onClick="return false;">
119+
(click)="show_connection_infO=false; " onClick="return false;">
120120
... Hide information</a>
121121
</div>
122122
<div class="col-6"
123123
*ngIf="cluster?.status != VirtualMachineStates.staticDELETED && cluster?.status != VirtualMachineStates.staticDELETING">
124124
<a class="font-weight-bold font-xs btn-block text-muted btn btn-outline-danger"
125125
[id]="'delete_'+cluster?.cluster_id"
126-
(click)="selectedCluster=cluster; verifyModal.show()" href="#" onClick="return false;">
126+
(click)="selectedCluster=cluster; verifyModal.show()" onClick="return false;">
127127
Delete</a>
128128

129129

@@ -144,7 +144,7 @@
144144
</div>
145145

146146
<div class="col-md-2" style="margin: auto" *ngIf="mode.copy_field && mode.copy_field!=''"><a
147-
(click)="copyToClipboard(mode.copy_field);" href="#"
147+
(click)="copyToClipboard(mode.copy_field);"
148148
onClick="return false;"
149149
class="font-weight-bold font-xs btn-block text-muted">&lt;copy
150150
command&gt;</a>

0 commit comments

Comments
 (0)
Please sign in to comment.