Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Analyze APIs, If Wrapped in JSON, Dont Wrap a Second Time #229

Open
davidvonthenen opened this issue May 30, 2024 · 0 comments
Open

For Analyze APIs, If Wrapped in JSON, Dont Wrap a Second Time #229

davidvonthenen opened this issue May 30, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers medium priority Do these second...
Milestone
Go SDK 1.7

Comments

@davidvonthenen
Copy link
Contributor

Proposed changes

Since the input is a file or a stream, usually a file but could be a StringBuffer), you wouldnt want the user to modify the document first to include the JSON.

We can detect if the input is valid JSON, then omit wrap in JSON if it is.

Please see:
https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/client/analyze/client.go#L148

Context

Possible Implementation

Other information
@davidvonthenen davidvonthenen added this to the Go SDK v1.4 milestone May 30, 2024
@davidvonthenen davidvonthenen modified the milestones: Go SDK v1.6, Go SDK 1.7 Nov 7, 2024
@davidvonthenen davidvonthenen added enhancement New feature or request good first issue Good for newcomers medium priority Do these second... labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers medium priority Do these second...
Projects
None yet
Milestone
Go SDK 1.7
Development

No branches or pull requests
1 participant
@davidvonthenen