Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a new feature to animate layers #77

Open
EmbraceLife opened this issue May 15, 2017 · 1 comment
Open

Propose a new feature to animate layers #77

EmbraceLife opened this issue May 15, 2017 · 1 comment

Comments

@EmbraceLife
Copy link
Contributor

I have made an animate feature to work. Should I make a PR for this? If so, how can I make a second PR while the first one is not accepted yet?
Thanks

@ajsyp
Copy link
Collaborator

ajsyp commented Jun 5, 2017

That looks pretty cool! Does it work by loading pre-saved files from the plot_weights hook? If this works for all layer types in Kur, then it could make sense for it to be part of Kur using the animate sub-command like you showed. On the other hand, if it only works for a certain set of models / layers, then it makes a lot of sense for it to be a plugin (I'll try to find some time to document the plugin features, so you have a template for how to write these).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants