Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DH-14692 Stop exporting client from support logs #2368

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Feb 13, 2025

Cherry-pick #2279

  • Move exportLogs and logInit to the log package so they could be reused in Enterprise
  • Remove @deephaven/redux and @deephaven/jsapi-shim dependencies from LogExport.ts
  • Serialize Maps in redux data
  • Unit tests for getReduxDataString

- Move `exportLogs` and `logInit` to the `log` package so they could be
reused in Enterprise
- Remove `@deephaven/redux` and `@deephaven/jsapi-shim` dependencies
from `LogExport.ts`
- Serialize Maps in redux data
- Unit tests for `getReduxDataString`
@ericlln ericlln requested a review from mofojed February 13, 2025 16:18
@ericlln ericlln self-assigned this Feb 13, 2025
@ericlln ericlln changed the title DH-14692: Stop exporting client from support logs refactor: DH-14692 Stop exporting client from support logs Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 46.70%. Comparing base (8e511a0) to head (4872a77).
Report is 1 commits behind head on release/v0.85.

Files with missing lines Patch % Lines
packages/log/src/LogExport.ts 20.00% 16 Missing ⚠️
packages/log/src/LogInit.ts 0.00% 3 Missing ⚠️
packages/code-studio/src/index.tsx 0.00% 2 Missing ⚠️
packages/code-studio/src/settings/SettingsMenu.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/v0.85    #2368      +/-   ##
=================================================
- Coverage          46.71%   46.70%   -0.01%     
=================================================
  Files                689      695       +6     
  Lines              38623    38814     +191     
  Branches            9624     9665      +41     
=================================================
+ Hits               18043    18130      +87     
- Misses             20570    20674     +104     
  Partials              10       10              
Flag Coverage Δ
unit 46.70% <15.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericlln ericlln merged commit fd17510 into deephaven:release/v0.85 Feb 14, 2025
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants