Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

debounce-handler: deal with component unmount #24

Open
user1736 opened this issue Oct 15, 2018 · 3 comments
Open

debounce-handler: deal with component unmount #24

user1736 opened this issue Oct 15, 2018 · 3 comments

Comments

@user1736
Copy link
Contributor

Hi there!

It's more of a question here. Let's say we have a callback with really big delay, in that case the callback might be invoked after the wrapped component had already been unmounted. Should debounce-handler do something with that? e.g. it might prevent debounced function from firing after component unmount, or force to run it right before component unmount, to ensure the last call done while component is still alive.

@deepsweet
Copy link
Owner

Sounds good to me, do you mind to make a PR?

@user1736
Copy link
Contributor Author

@deepsweet sure, I'll try to get to it on upcoming weekend

@jmcpeak
Copy link

jmcpeak commented Feb 17, 2019

I just ran into this issue - has it been resolved?

This library made it easy to debounce with recompose - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants