Skip to content

Remove or update ll2sphere_xyz? #131

Description

@espg

We currently have this function inside of Utils:

https://github.com/demiangomez/Parallel.GAMIT/blob/e0dc45bc3f2fb294613bac41cac0b0622e7cdbbc/pgamit/Utils.py#L76-L84

The function as written:

  1. Does not specify or document the input order for lat and lon coordinates (which 'L' is which??)
  2. Ignores elevation / altitude completely during the transform (only calls columns 1 and 3 of a three column "ell" array)
  3. Does a spherical transform, which is potentially in conflict with the ellipsoidal ecef coordinates that are used in pgamit

Is anything using this function? Can we remove it, or should it updated to include the ellipsoid , use altitude/elevation, and have a docstring?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions