Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno_core is not compiling when added as dependency #27876

Open
renardeinside opened this issue Jan 30, 2025 · 1 comment
Open

deno_core is not compiling when added as dependency #27876

renardeinside opened this issue Jan 30, 2025 · 1 comment
Labels
embedder Embedders using deno crates to build their own runtime rather than using Deno itself

Comments

@renardeinside
Copy link

Cargo.toml:

[package]
name = "test-lib"
version = "0.1.0"
edition = "2021"

[dependencies]
deno_runtime = "0.195.0"

Build:

cargo build --lib

Error trace:

error[E0308]: mismatched types
    --> /Users/renarde/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.331.0/inspector.rs:261:55
     |
261  |     let stack_trace = v8_inspector.create_stack_trace(stack_trace);
     |                                    ------------------ ^^^^^^^^^^^ expected `Option<Local<'_, StackTrace>>`, found `Local<'_, StackTrace>`
     |                                    |
     |                                    arguments to this method are incorrect
     |
     = note: expected enum `std::option::Option<Local<'_, _>>`
              found struct `Local<'_, _>`
note: method defined here
    --> /Users/renarde/.cargo/registry/src/index.crates.io-6f17d22bba15001f/v8-130.0.8/src/inspector.rs:1042:10
     |
1042 |   pub fn create_stack_trace(
     |          ^^^^^^^^^^^^^^^^^^
help: try wrapping the expression in `Some`
     |
261  |     let stack_trace = v8_inspector.create_stack_trace(Some(stack_trace));
     |                                                       +++++           +

@renardeinside renardeinside marked this as a duplicate of #27874 Jan 30, 2025
@renardeinside renardeinside marked this as a duplicate of #27875 Jan 30, 2025
@renardeinside
Copy link
Author

Upd: unrelated to deno, something was broken in v8. Maybe fixing versions explicitly in deno deps would make it more stable.

@marvinhagemeister marvinhagemeister added the embedder Embedders using deno crates to build their own runtime rather than using Deno itself label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedder Embedders using deno crates to build their own runtime rather than using Deno itself
Projects
None yet
Development

No branches or pull requests

2 participants