Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): make readDir streaming #17311

Closed
wants to merge 9 commits into from
Closed

fix(runtime): make readDir streaming #17311

wants to merge 9 commits into from

Conversation

crowlKats
Copy link
Member

Fixes #4218

bartlomieju
bartlomieju reviewed Jan 9, 2023
View reviewed changes
bartlomieju
bartlomieju reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for resource_unavailable, and does any other test should be updated?

bartlomieju
bartlomieju approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments, seems like a reasonable fix

@crowlKats crowlKats marked this pull request as draft January 24, 2023 14:04
@crowlKats crowlKats marked this pull request as ready for review January 31, 2023 21:25
@crowlKats crowlKats marked this pull request as draft February 11, 2023 20:09
aapoalas
aapoalas requested changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rebase.

I'm also wondering what the performance of this solution is compared to the existing one?

@crowlKats crowlKats closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas requested changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Deno.readDir actually streaming
3 participants
@crowlKats @bartlomieju @aapoalas