Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op_crates/fetch): Add a cookie jar to fetch #10085

Closed
wants to merge 2 commits into from
Closed

feat(op_crates/fetch): Add a cookie jar to fetch #10085

wants to merge 2 commits into from

Conversation

Liamolucko
Copy link
Contributor

Resolves #5862, by enabling the cookie functionality built into reqwest.

lucacasonato
lucacasonato requested changes Apr 9, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to preemptively block this until I manage to do a full review. This is something that needs the very very very carefully considered because it is very security sensitive. This should in no scenario be enabled by default.

@bartlomieju bartlomieju added this to the 1.10.0 milestone Apr 9, 2021
@Liamolucko
Copy link
Contributor Author

This approach doesn't really work, actually, because we need to support credentials: "omit" and reqwest doesn't seem to support enabling cookies per-request. I might make another attempt at implementing this in JS, but I'll close this PR.

@Liamolucko Liamolucko closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Deno lacks a cookie jar for fetch
3 participants
@Liamolucko @lucacasonato @bartlomieju