Skip to content

Commit 1189057

Browse files
committed
clean
1 parent 7c13fa1 commit 1189057

File tree

5 files changed

+29
-22
lines changed

5 files changed

+29
-22
lines changed

Cargo.lock

+16-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+4-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ members = ["lib"]
1515
[workspace.dependencies]
1616
deno_unsync = { version = "0.4.0", default-features = false }
1717
thiserror = "2"
18-
deno_error = "0.5.1"
18+
deno_error = "0.5.2"
1919

2020
[lib]
2121
name = "deno_graph"
@@ -82,3 +82,6 @@ codegen-units = 1
8282
incremental = true
8383
lto = true
8484
opt-level = "z"
85+
86+
[patch.crates-io]
87+
deno_error = { path = "../deno_error" }

src/graph.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -4782,7 +4782,9 @@ impl<'a, 'graph> Builder<'a, 'graph> {
47824782
load_specifier.clone(),
47834783
maybe_range.cloned(),
47844784
if maybe_version_info.is_some() {
4785-
JsrLoadError::ContentChecksumIntegrity(err).into()
4785+
ModuleLoadError::Jsr(JsrLoadError::ContentChecksumIntegrity(
4786+
err,
4787+
))
47864788
} else {
47874789
ModuleLoadError::HttpsChecksumIntegrity(err)
47884790
},

src/lib.rs

+4-3
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ mod tests {
193193

194194
use super::*;
195195
use async_trait::async_trait;
196+
use deno_error::JsErrorBox;
196197
use indexmap::IndexMap;
197198
use indexmap::IndexSet;
198199
use pretty_assertions::assert_eq;
@@ -4583,9 +4584,9 @@ export function a(a: A): B {
45834584
ResolutionKind::Execution => {
45844585
Ok(resolve_import(specifier_text, &referrer_range.specifier)?)
45854586
}
4586-
ResolutionKind::Types => {
4587-
Err(source::ResolveError::Other(Box::new(FailedError)))
4588-
}
4587+
ResolutionKind::Types => Err(source::ResolveError::Other(
4588+
JsErrorBox::from_err(FailedError),
4589+
)),
45894590
}
45904591
}
45914592
}

src/source/mod.rs

+2-8
Original file line numberDiff line numberDiff line change
@@ -392,14 +392,8 @@ pub enum ResolveError {
392392
#[error(transparent)]
393393
ImportMap(#[from] import_map::ImportMapError),
394394
#[class(inherit)]
395-
#[error("{0}")]
396-
Other(Box<dyn JsErrorClass>),
397-
}
398-
399-
impl<T: JsErrorClass> From<Box<T>> for ResolveError {
400-
fn from(value: Box<T>) -> Self {
401-
Self::Other(value)
402-
}
395+
#[error(transparent)]
396+
Other(#[from] deno_error::JsErrorBox),
403397
}
404398

405399
/// The kind of resolution currently being done by deno_graph.

0 commit comments

Comments
 (0)