Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin to get remote IP from HTTP-Header #2016

Closed
git001 opened this issue Nov 6, 2023 · 1 comment
Closed

Add a plugin to get remote IP from HTTP-Header #2016

git001 opened this issue Nov 6, 2023 · 1 comment

Comments

@git001
Copy link

git001 commented Nov 6, 2023

As in #1827 discussed the remote IP from a client could be different the the remoteAddr Variable. Some Applications, nowadays, run behind a reverse proxy and send the real client IP in http headers like X-Forwarded-For or Forwarded HTTP Extension which should be parsed and set the remoteAddr, or another Variable, with that header value.

There are two to-do's from my point of view.

[ ] Implement Forwarded and/or X-Forwarded-For Parser in a fresh plugin
[ ] Create a example to show the usage of the plugin.

@marvinhagemeister
Copy link
Collaborator

No, as described in #1827 this should not live in the Fresh code base at all, neither directly in Fresh, nor as a plugin. Adding it to the Fresh repository would imply that we would keep it up to date and maintain it. We won't do that. It should either live in the project's code directly as a middleware or as a plugin in a separate repository. I'm happy to point to that from the docs once a repository for a plugin exists or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants