add to node tests

Author: easrng

_tools/node_test_runner/run_test.mjs

@@ -73,7 +73,10 @@ import "../../fs/unstable_lstat_test.ts";
 import "../../fs/unstable_chmod_test.ts";
 import "../../fs/unstable_umask_test.ts";
 import "../../fs/unstable_utime_test.ts";
+import "../../internal/format_test.ts";
 
 for (const testDef of testDefinitions) {
-  test(testDef.name, testDef.fn);
+  test(testDef.name, (t) =>
+    testDef.fn({ step: (name, fn) => t.test(name, fn) })
+  );
 }

internal/format.ts

@@ -22,20 +22,27 @@
 export function format(v: unknown): string {
   // deno-lint-ignore no-explicit-any
   const { Deno, process } = globalThis as any;
-  const options = {
-    depth: Infinity,
-    sorted: true,
-    trailingComma: true,
-    compact: false,
-    iterableLimit: Infinity,
-    // getters should be true in assertEquals.
-    getters: true,
-    strAbbreviateSize: Infinity,
-  };
 
   return typeof Deno?.inspect === "function"
-    ? Deno.inspect(v, options)
+    ? Deno.inspect(v, {
+      depth: Infinity,
+      sorted: true,
+      trailingComma: true,
+      compact: false,
+      iterableLimit: Infinity,
+      // getters should be true in assertEquals.
+      getters: true,
+      strAbbreviateSize: Infinity,
+    })
     : typeof process?.getBuiltinModule === "function"
-    ? process.getBuiltinModule("node:util").inspect(v, options)
+    ? process.getBuiltinModule("node:util").inspect(v, {
+      depth: Infinity,
+      sorted: true,
+      compact: false,
+      iterableLimit: Infinity,
+      // getters should be true in assertEquals.
+      getters: true,
+      strAbbreviateSize: Infinity,
+    })
     : `"${String(v).replace(/(?=["\\])/g, "\\")}"`;
 }

internal/format_test.ts

@@ -21,46 +21,47 @@ ${red("-   d")}
   );
 });
 
-// Check that the diff formatter overrides some default behaviours of
-// `Deno.inspect()` which are problematic for diffing.
-Deno.test("format() overrides default behaviours of Deno.inspect", async (t) => {
-  // Wraps objects into multiple lines even when they are small. Prints trailing
-  // commas.
-  await t.step(
-    "format() always wraps objects into multiple lines and prints trailing commas",
-    () =>
-      assertEquals(
-        stripAnsiCode(format({ a: 1, b: 2 })),
-        `{
+if (typeof Deno.inspect === "function") {
+  // Check that the diff formatter overrides some default behaviours of
+  // `Deno.inspect()` which are problematic for diffing.
+  Deno.test("format() overrides default behaviours of Deno.inspect", async (t) => {
+    // Wraps objects into multiple lines even when they are small. Prints trailing
+    // commas.
+    await t.step(
+      "format() always wraps objects into multiple lines and prints trailing commas",
+      () =>
+        assertEquals(
+          stripAnsiCode(format({ a: 1, b: 2 })),
+          `{
   a: 1,
   b: 2,
 }`,
-      ),
-  );
+        ),
+    );
 
-  await t.step("format() sorts properties", () =>
-    assertEquals(
-      format({ b: 2, a: 1 }),
-      format({ a: 1, b: 2 }),
-    ));
+    await t.step("format() sorts properties", () =>
+      assertEquals(
+        format({ b: 2, a: 1 }),
+        format({ a: 1, b: 2 }),
+      ));
 
-  await t.step("format() wraps Object with getters", () =>
-    assertEquals(
-      format(Object.defineProperty({}, "a", {
-        enumerable: true,
-        get() {
-          return 1;
-        },
-      })),
-      `{
+    await t.step("format() wraps Object with getters", () =>
+      assertEquals(
+        format(Object.defineProperty({}, "a", {
+          enumerable: true,
+          get() {
+            return 1;
+          },
+        })),
+        `{
   a: [Getter: 1],
 }`,
-    ));
+      ));
 
-  await t.step("format() wraps nested small objects", () =>
-    assertEquals(
-      stripAnsiCode(format([{ x: { a: 1, b: 2 }, y: ["a", "b"] }])),
-      `[
+    await t.step("format() wraps nested small objects", () =>
+      assertEquals(
+        stripAnsiCode(format([{ x: { a: 1, b: 2 }, y: ["a", "b"] }])),
+        `[
   {
     x: {
       a: 1,
@@ -72,13 +73,13 @@ Deno.test("format() overrides default behaviours of Deno.inspect", async (t) =>
     ],
   },
 ]`,
-    ));
+      ));
 
-  // Grouping is disabled.
-  await t.step("format() disables grouping", () =>
-    assertEquals(
-      stripAnsiCode(format(["i", "i", "i", "i", "i", "i", "i"])),
-      `[
+    // Grouping is disabled.
+    await t.step("format() disables grouping", () =>
+      assertEquals(
+        stripAnsiCode(format(["i", "i", "i", "i", "i", "i", "i"])),
+        `[
   "i",
   "i",
   "i",
@@ -87,30 +88,31 @@ Deno.test("format() overrides default behaviours of Deno.inspect", async (t) =>
   "i",
   "i",
 ]`,
-    ));
-});
-
-Deno.test("format() doesn't truncate long strings in object", () => {
-  const str = format({
-    foo:
-      "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+      ));
   });
-  assertEquals(
-    str,
-    `{
+
+  Deno.test("format() doesn't truncate long strings in object", () => {
+    const str = format({
+      foo:
+        "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+    });
+    assertEquals(
+      str,
+      `{
   foo: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
 }`,
-  );
-});
+    );
+  });
+}
 
 Deno.test("format() has fallback to util.inspect if Deno.inspect is not available", async (t) => {
   // Simulates the environment where Deno.inspect is not available
   const inspect = Deno.inspect;
   // deno-lint-ignore no-explicit-any
   delete (Deno as any).inspect;
   try {
-    assertEquals(format([..."abcd"]), `[\n  'a',\n  'b',\n  'c',\n  'd',\n]`);
-    assertEquals(format({ a: 1, b: 2 }), `{\n  a: 1,\n  b: 2,\n}`);
+    assertEquals(format([..."abcd"]), `[\n  'a',\n  'b',\n  'c',\n  'd'\n]`);
+    assertEquals(format({ a: 1, b: 2 }), `{\n  a: 1,\n  b: 2\n}`);
     await t.step("format() sorts properties", () =>
       assertEquals(
         format({ b: 2, a: 1 }),
@@ -126,7 +128,7 @@ Deno.test("format() has fallback to util.inspect if Deno.inspect is not availabl
           },
         })),
         `{
-  a: [Getter: 1],
+  a: [Getter: 1]
 }`,
       ));
 
@@ -137,13 +139,13 @@ Deno.test("format() has fallback to util.inspect if Deno.inspect is not availabl
   {
     x: {
       a: 1,
-      b: 2,
+      b: 2
     },
     y: [
       'a',
-      'b',
-    ],
-  },
+      'b'
+    ]
+  }
 ]`,
       ));
 
@@ -158,9 +160,21 @@ Deno.test("format() has fallback to util.inspect if Deno.inspect is not availabl
   'i',
   'i',
   'i',
-  'i',
+  'i'
 ]`,
       ));
+    await t.step("format() doesn't truncate long strings in object", () => {
+      const str = format({
+        foo:
+          "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+      });
+      assertEquals(
+        str,
+        `{
+  foo: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+}`,
+      );
+    });
   } finally {
     Deno.inspect = inspect;
   }
@@ -174,6 +188,7 @@ Deno.test("format() has fallback to String if util.inspect and Deno.inspect are
   // deno-lint-ignore no-explicit-any
   const { process } = globalThis as any;
   const getBuiltinModule = process.getBuiltinModule;
+  delete process.getBuiltinModule;
   try {
     assertEquals(format([..."abcd"]), `"a,b,c,d"`);
     assertEquals(format({ a: 1, b: 2 }), `"[object Object]"`);