Add support for dotnet .slnx solution files
#11694
Conversation
austindrenski
force-pushed
the
patch-1
branch
2 times, most recently
from
1606ce5 to
61e9d8c
Compare
austindrenski
force-pushed
the
patch-1
branch
from
61e9d8c to
d83d929
Compare
|
@austindrenski One required spec is failing, you may like to check this. |
| (solutionPath, """ | ||
| <Solution> | ||
| <Folder Name="/src/"> | ||
| <Project Path="src/project.csproj" /> |
There was a problem hiding this comment.
Could you use a backslash here? The updater ultimately runs on Linux and unit tests run on Linux, too, and using "src\project.csproj" instead of "src/project.csproj" would help make sure the paths were normalized.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Some.Package" /> |
There was a problem hiding this comment.
Add the Version attribute here and drop the files Directory.Build.props, Directory.Packages.props, global.json, and dotnet-tools.json. I'd rather the test be constrained to just validating .slnx expansion.
| ("src/project.csproj", """ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net7.0;net8.0</TargetFrameworks> |
There was a problem hiding this comment.
Just a single target framework should suffice since the desired behavior is verifying .slnx expansion and nothing else.
| @@ -232,6 +236,30 @@ private static ImmutableArray<string> ExpandEntryPointsIntoProjects(IEnumerable< | |||
| filesToExpand.Push(project.AbsolutePath); | |||
| } | |||
| } | |||
| else if (extension == ".slnx") | |||
| { | |||
| var projects = XElement | |||
There was a problem hiding this comment.
Use the official .slnx parser added in this PR instead of direct XML loading; I'm not paid enough to edit this when the official parser does something unexpected in 3 years :)
Fixes: #11671
What are you trying to accomplish?
.slnxsolution formatAnything you want to highlight for special attention from reviewers?
This format is relatively new, but at this point Visual Studio, JetBrains Rider, and the dotnet CLI all support building both
.slnand.slnxfiles.I've got a group of very eager devs, myself included, who are migrating ancient
.slnfiles to.slnxformat, and so far the biggest blocker is a lack of dependabot support.So, recognizing that this PR may not cover all of the interesting corner cases, I'm hoping it might at least get the ball rolling since, as far as I can tell, dependabot only uses
.slnfiles as graph roots to crawl for project files, and that's (breathtakingly) straightforward in the new XML-based.slnxformat.How will you know you've accomplished your goal?
.slnxis already in use.Checklist