Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this repo be deleted? #1

Open
jeffwidman opened this issue Apr 28, 2021 · 5 comments
Open

Should this repo be deleted? #1

jeffwidman opened this issue Apr 28, 2021 · 5 comments

Comments

@jeffwidman
Copy link
Member

I'm trying to debug a problem with go modules, and it's confusing seeing this repo... is it actively used (or planned to be used) or should it be deleted?

@jeffwidman
Copy link
Member Author

nudge @jurre

@jurre
Copy link
Member

jurre commented Feb 17, 2022

I'm not sure if it's actively used, but we do have a tonne of references to it in our dependabot-core test fixtures and I'm worried that deleting the repo will cause those tests to fail.

@jeffwidman
Copy link
Member Author

Ah yeah, I didn't even think to check for those since I assumed this repo was some standalone experimentation thing. Makes sense. If you don't mind, maybe hold this ticket open for a bit as a reminder to see if those fixtures are easy to eventually update to drop this dep.

@jeffwidman
Copy link
Member Author

Note to self: See also dependabot/dependabot-core@36daf87

That said, the entire directory https://github.com/dependabot/dependabot-core/commits/main/go_modules/spec/fixtures/go_mods looks like it predates storing all the test repos in https://github.com/dependabot/dependabot-core/tree/main/go_modules/spec/fixtures/projects

So I have a funny feeling this can be migrated to https://github.com/dependabot/dependabot-core/tree/main/go_modules/spec/fixtures/projects and then removed...

If possible, that would certainly reduce confusion...

@jurre
Copy link
Member

jurre commented Mar 15, 2022

looks like it predates storing all the test repos in https://github.com/dependabot/dependabot-core/tree/main/go_modules/spec/fixtures/projects

Yep it does, there are a few tests lingering around that still reference those old files, but I agree that migrating everything to the project based fixtures would be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants