GitLab CI/CD does not work as advertised in documentation

[sgrossberndt]

When creating a CI job as documented at https://deployer.org/docs/7.x/ci-cd#gitlab-cicd the deployment fails with
/bin/bash: dep: command not found

The problem is probably that setting an empty entrypoint: [""] is required to be able to execute the before_script to add the SSH key, but inside the image the command dep is not known

The default entrypoint is to run php /bin/deployer.phar:
https://hub.docker.com/layers/deployphp/deployer/v7/images/sha256-442a2f14be51abdd61d2c102bd1c8631b5b1bbd76fb1f4999250e0f9c2557a4e

Running deployer with

  script:
    - php /bin/deployer.phar deploy -vvv

works, so the problem is only the missing dep command.

The recently added bitbucket-example uses php /bin/deployer.phar.

Either

• the documentation for GitLab CI/CD should be adapted to use php /bin/deployer.phar instead of dep in script
  or
• the image layers of the docker image should be adapted to allow calling dep.

[alexgit2k]

sgrossberndt is right, https://github.com/deployphp/deployer/blob/7.x/docs/ci-cd.md?plain=1#L73 says:

deployer/docs/ci-cd.md

Line 73 in 101da0f

- dep deploy -vvv

but Image https://github.com/deployphp/deployer/blob/7.x/Dockerfile#L9 runs

deployer/Dockerfile

Line 9 in 101da0f

ENTRYPOINT ["php", "/bin/deployer.phar"]

In the master for the upcoming version 8 it has been changed from php /bin/deployer.phar to /bin/dep in e6c5aae.

@antonmedv So please integrate the commit e6c5aae also in the version 7 branch so that dep can be used and no change is required here when switching to 8.

[alexgit2k]

Thanks! I can confirm that it is working now.

Is there any reason not to use PHP 8 for Deployer v7? Deployer v8 is on alpha-state, PHP 7.4 reached EOL in December 2022 and the image php:7.4-cli-alpine contains a lot of Vulnerabilities .
Maybe you can consider a separate Docker image with PHP 8 just for Deployer v7.

[antonmedv]

It is for compatibility reasons.

contains a lot of Vulnerabilities .

Uff! I didn't know. I will update to php8 as well.

[NickVulkers]

@antonmedv This seems to break Magento 2 deployments, the array_is_list function is used in it's recipe:

deployer/recipe/magento2.php

Line 191 in bd1b91d

$themes = array_is_list(get('magento_themes')) ? get('magento_themes') : array_keys(get('magento_themes'));

array_is_list() requires PHP >= 8.1.0.

My current temporary workaround is to unset the themes if you have set any, for example:

set('magento_themes', [
     'Magento/luma'   => null,
     'Custom/theme'   => 'en_US fr_FR'
]);

back to:

set('magento_themes', [
    
]);

[antonmedv]

Could you please add a PR to 7.x branch with array_is_list polyfill?

[NickVulkers]

@antonmedv #4019 should be sufficient I think.