Hookes executed out of order

[joeshelton-wagento]

Deployer Version

v8.0.5

Target OS

MacOS 14.8.9

Which PHP version are you using?

PHP 8.5

Content of deploy.php or deploy.yaml

{
  # You can import other php or maml recipes.
  # Import recipes directly from recipe/ folder.
  import: [
    "recipe/magento2.php"
  ]

  config: {
    repository: "git@bitbucket.org:wagento-global/paas-poc.git"
    deploy_path: "~"
    current_path: "public_html"
    writable_mode: "chmod"
    use_relative_symlink: true # this is OS dependant
  }

  # Hosts
  hosts: {
    # Build artifact in pipeline
    "localhost": {
      local: true
    }
    # Deploy to proper host
    "production": {
      remote_user: "deployer"
      hostname: "fake.com"
      port: 29064
      branch: "main"
      "bin/php": "cd {{release_or_current_path}}/{{magento_dir}} && .paas/cli bash php"
      "bin/magento": "bin/magento"
    }
    # For testing locally
    "testbuild": {
      local: true
      build_from_repo: true
      artifact_dir: "testdeploy"
      branch: "main"
      artifact_excludes_file: ".paas/artifacts/excludes"
    }
    "testdeploy": {
      local: true
      deploy_path: "/Volumes/ProjectFiles/paas-poc/testdeploy"
      artifact_dir: "testdeploy"
      enable_zero_downtime: false
      "bin/php": "cd {{release_or_current_path}}/{{magento_dir}} && .paas/cli bash php"
      "bin/magento": "bin/magento"
    }
  }

  # Define tasks as list of steps to run,
  # or use array to strings to define group task.
  tasks: {
    # Manage Docker containers
    "docker:pull": [
      {
        run: "cd {{release_path}} && .paas/cli docker pull"
      }
    ]
    "docker:up": [
      {
        run: "cd {{release_path}} && .paas/cli up --remove-orphans"
      }
    ]
    "docker:down": [
      {
        run: "if [ -d {{previous_release}} ]; then cd {{previous_release}} && .paas/cli down; fi"
      }
    ]
    # Disable / enable cron
    "cron:disable-and-wait": [
      {
        run: "if [ -d {{current_path}} ]; then {{bin/php}} {{current_path}}/bin/magento cron:remove || true; fi"
      }
      {
        run: "cd {{release_path}} && bash -c 'TIMEOUT=120; ELAPSED=0; while .paas/cli docker exec -T fpm pgrep -f \"bin/magento +(cron:run)\" > /dev/null 2>&1; do if [ $ELAPSED -ge $TIMEOUT ]; then echo \"Timeout reached waiting for crons, proceeding...\"; break; fi; echo \"Waiting for active cron jobs to finish... ($ELAPSED/${TIMEOUT}s)\"; sleep 5; ELAPSED=$((ELAPSED+5)); done'"
      }
    ]
    "cron:enable": [
      {
        run: "cd {{release_path}} && {{bin/php}} {{bin/magento}} cron:install"
      }
    ]
  }

  # Hooks
  after: {
    # restart Docker with new definition
    # disable cron during deployment
    "magento:maintenance:enable-if-needed": [
      "cron:disable-and-wait"
      "docker:down"
      "docker:pull"
      "docker:up"
    ]
    "deploy:symlink": "cron:enable"
  }
}

Steps to reproduce

Hooks are executed in the opposite order that they are defined. MAML configuration file. Multiple commands defined in one hook.

Command: dep artifact:deploy testdeploy

Output:

[madhav669]

This looks like a bug in the recipe importers, not in your config. The two hook types store tasks differently, but the importer handles a list the same way for both.

In src/Task/Task.php the two hook types insert at opposite ends:

public function addBefore(string $task): self
{
    array_unshift($this->before, $task);   // prepends
    return $this;
}

public function addAfter(string $task): self
{
    array_push($this->after, $task);       // appends
    return $this;
}

But src/Import/MamlRecipe.php (and YamlRecipe.php too) does the same thing for a list in both cases:

if (is_array($value)) {
    foreach (array_reverse($value) as $v) {
        after($key, $v);   // same array_reverse is used for before()
    }
}

For before, reversing and then prepending gives you the original order back, which is correct. For after, reversing and then appending leaves the list reversed. So your list runs as docker:up, docker:pull, docker:down, cron:disable-and-wait, which matches your screenshot. ScriptManager runs getAfter() in array order, so nothing later corrects it. The same array_reverse was already in v7's Importer::after(), so this isn't a v8 regression. It's only noticeable when you give after a list in YAML/MAML. In a PHP recipe, separate after() calls run in the order you write them.

Workaround that doesn't depend on the bug: turn the steps into a group task and hook that single task. In MAML, a task whose body is an array of strings becomes a GroupTask, and those run in the order listed:

tasks: {
  # ...your existing docker:* / cron:* tasks...

  "deploy:prepare-runtime": [
    "cron:disable-and-wait"
    "docker:down"
    "docker:pull"
    "docker:up"
  ]
}

after: {
  "magento:maintenance:enable-if-needed": "deploy:prepare-runtime"
  "deploy:symlink": "cron:enable"
}

You could also just write the list in reverse, but that silently breaks once the bug is fixed, so I wouldn't.

The fix itself is a one-liner: drop the array_reverse in after() in both MamlRecipe.php and YamlRecipe.php, and keep it in before(). It'd be worth opening an issue/PR with a small test. For example, after: { a: ["b", "c"] } should give getAfter() === ['b', 'c'].

[joeshelton-wagento]

Thanks so much! Are you suggesting I create an issue/PR? I did create this thread from the Issues tab. Not sure why it posted here in Discussions. Since you found the solution, the PR credit should go to you, I think.