Merge pull request #34 from depot/feat/sni-servername

goller · web-flow · commit dea53b5569fd · 2024-05-22T14:28:18.000-05:00
feat: require mTLS server name check
diff --git a/machine/machine.go b/machine/machine.go
@@ -179,7 +179,7 @@ func (m *Machine) Client(ctx context.Context) (*client.Client, error) {
 		}
 		caCert := file.Name()
 
-		opts = append(opts, client.WithCredentials(cert, key), client.WithServerConfig("", caCert))
+		opts = append(opts, client.WithCredentials(cert, key), client.WithServerConfig(m.ServerName, caCert))
 	}
 
 	c, err := client.New(ctx, m.Addr, opts...)

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ func (m Machine) Client(ctx context.Context) (client.Client, error) {`
`179`	`179`	`}`
`180`	`180`	`caCert := file.Name()`
`181`	`181`
`182`		`- opts = append(opts, client.WithCredentials(cert, key), client.WithServerConfig("", caCert))`
	`182`	`+ opts = append(opts, client.WithCredentials(cert, key), client.WithServerConfig(m.ServerName, caCert))`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`c, err := client.New(ctx, m.Addr, opts...)`