Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label not found when using button with exotic role (eg checkbox) #4401

Closed
1 task done
csmatt opened this issue Apr 8, 2024 · 1 comment
Closed
1 task done

Label not found when using button with exotic role (eg checkbox) #4401

csmatt opened this issue Apr 8, 2024 · 1 comment

Comments

@csmatt
Copy link

csmatt commented Apr 8, 2024

Product

axe-core

Product Version

4.8.4

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

Describe what you expected the product to do.

Actual

Describe what the product actually does.
axe should find the label via label-for with the button role=combobox or role=checkbox associated via id

How to Reproduce

Provide a code sample or link to a webpage that reproduces the issue. Without this, your issue may be closed without investigation.

The best way to reproduce is to go to the shadcn page for their <Select> component and run the axe extension on the page. It will be the last violation under 'Buttons must have discernible text'.

It can also be seen via the shadcn page for their <Checkbox> component as the second violation under 'Buttons must have discernible text'.

Additional context

Any thing else we should know about the issue?

I also see the issue when running the axe Jest extension so I believe this is an issue in core.

@csmatt csmatt added the ungroomed Ticket needs a maintainer to prioritize and label label Apr 8, 2024
@straker
Copy link
Contributor

straker commented Apr 8, 2024

Thanks for the issue. I believe this is related to #3696 where button elements using label aren't supported in Dragon Naturally Speaking so we continue to flag them as issues. We've been meaning to add a "not well supported" message but just haven't gotten around to it.

@straker straker removed the ungroomed Ticket needs a maintainer to prioritize and label label Apr 8, 2024
@straker straker closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants