Skip to content

Commit d7346bb

Browse files
committed
docker: Drop redundant build and update workflows
1 parent 6d717fd commit d7346bb

File tree

3 files changed

+12
-21
lines changed

3 files changed

+12
-21
lines changed

.github/workflows/docker-bases.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,6 @@ jobs:
7272
dockerfile: './docker/Dockerfile.cpu'
7373
runner: ubuntu-latest
7474

75-
- tag: 'devitocodes/bases:cpu-icx'
76-
arch: 'arch=icx'
77-
version: ''
78-
dockerfile: './docker/Dockerfile.cpu'
79-
runner: ubuntu-latest
80-
8175
- tag: 'devitocodes/bases:cpu-nvc'
8276
arch: 'arch=nvc-host'
8377
version: ''

.github/workflows/pytest-core-nompi.yml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434
pytest-ubuntu-py39-gcc9-omp,
3535
pytest-osx-py37-clang-omp,
3636
pytest-docker-py37-gcc-omp,
37-
pytest-docker-py37-icc-omp,
38-
pytest-docker-py38-icx-omp
37+
pytest-docker-py37-intel-omp,
38+
pytest-docker-py38-intel-omp
3939
]
4040
set: [base, adjoint]
4141
include:
@@ -95,14 +95,14 @@ jobs:
9595
language: "openmp"
9696
sympy: "1.10"
9797

98-
- name: pytest-docker-py37-icc-omp
98+
- name: pytest-docker-py37-intel-omp
9999
python-version: '3.7'
100100
os: ubuntu-22.04
101101
arch: "icc"
102102
language: "openmp"
103103
sympy: "1.11"
104104

105-
- name: pytest-docker-py38-icx-omp
105+
- name: pytest-docker-py38-intel-omp
106106
python-version: '3.8'
107107
os: ubuntu-22.04
108108
arch: "icx"
@@ -129,15 +129,20 @@ jobs:
129129
with:
130130
python-version: ${{ matrix.python-version }}
131131

132-
- name: Build docker image
133-
if: contains(matrix.name, 'docker')
132+
- name: Build docker image for GCC variants
133+
if: "contains(matrix.name, 'docker') && contains(matrix.name, 'gcc')"
134134
run: |
135135
docker build . --file docker/Dockerfile.devito --tag devito_img --build-arg base=devitocodes/bases:cpu-${{ matrix.arch }}
136136
137+
- name: Build docker image for INTEL variants
138+
if: "contains(matrix.name, 'docker') && contains(matrix.name, 'intel')"
139+
run: |
140+
docker build . --file docker/Dockerfile.devito --tag devito_img --build-arg base=devitocodes/bases:cpu-icc
141+
137142
- name: Set run prefix
138143
run: |
139144
if [[ "${{ matrix.name }}" =~ "docker" ]]; then
140-
echo "RUN_CMD=docker run --rm -e CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }} --name testrun devito_img" >> $GITHUB_ENV
145+
echo "RUN_CMD=docker run --rm -e CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }} -e DEVITO_ARCH=${{ matrix.arch }} --name testrun devito_img" >> $GITHUB_ENV
141146
else
142147
echo "RUN_CMD=" >> $GITHUB_ENV
143148
fi

docker/Dockerfile.cpu

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,6 @@ ENV DEVITO_LANGUAGE="openmp"
5555
# MPICC compiler for mpi4py
5656
ENV MPICC=$I_MPI_ROOT/bin/mpiicc
5757

58-
##############################################################
59-
# ICX image
60-
##############################################################
61-
FROM icc as icx
62-
63-
# Devito config
64-
ENV DEVITO_ARCH="icx"
65-
6658
##############################################################
6759
# Published image
6860
##############################################################

0 commit comments

Comments
 (0)