Merge branch 'master' into attributes/fix_compile_errors_from_fix_integer_conversion_errors

Author: grenewode

examples/base/array.cc

@@ -1,11 +1,18 @@
 //  This file is part of Empirical, https://github.com/devosoft/Empirical
-//  Copyright (C) Michigan State University, 2016-2017.
+//  Copyright (C) Michigan State University, 2016-2018.
 //  Released under the MIT Software license; see doc/LICENSE
 
 #include "base/array.h"
 
 #define A_SIZE 50
 
+// Function to print an std::array; will it work with emp::array?
+template <size_t N>
+void ArrayPrint(const std::array<int,N> & ar) {
+  for (int x : ar) std::cout << x << " ";
+  std::cout << std::endl;
+}
+
 int main()
 {
   emp::array<int, A_SIZE> test_array;
@@ -14,6 +21,9 @@ int main()
     test_array[i] = (int) (i * i);
   }
 
+  std::cout << "First array: " << std::endl;
+  ArrayPrint<A_SIZE>(test_array);
+
   int sum = 0;
   for (size_t i = 0; i < A_SIZE; i++) {
     sum += test_array[i];

examples/data/Makefile

@@ -5,6 +5,7 @@ CFLAGS_version := -std=c++14
 # Emscripten compiler information
 CXX_web := emcc
 CXX_native := g++
+#CXX_native := clang++
 
 OFLAGS_native_debug := -g -pedantic -DEMP_TRACK_MEM  -Wnon-virtual-dtor -Wcast-align -Woverloaded-virtual -Wconversion -Weffc++
 OFLAGS_native_opt := -O3 -DNDEBUG

examples/timing/pointers.cc

@@ -25,7 +25,7 @@ int main()
   std::clock_t base_start_time = std::clock();
 
   std::vector<int *> v_base(N);
-  for (size_t i = 0; i < N; i++) v_base[i] = new int((i*7)%N);
+  for (size_t i = 0; i < N; i++) v_base[i] = new int((int)((i*7)%N));
   std::vector<int *> v_base2(v_base);
   std::sort( v_base2.begin(), v_base2.end(), [](int *p1,int *p2){ return *p1 < *p2; } );
   v_base.resize(0);
@@ -43,7 +43,7 @@ int main()
   std::clock_t std_start_time = std::clock();
 
   std::vector<std::shared_ptr<int>> v_std(N);
-  for (size_t i = 0; i < N; i++) v_std[i] = std::make_shared<int>( (i*7)%N );
+  for (size_t i = 0; i < N; i++) v_std[i] = std::make_shared<int>( (int)((i*7)%N) );
   std::vector<std::shared_ptr<int>> v_std2(v_std);
   std::sort( v_std2.begin(), v_std2.end(),
              [](std::shared_ptr<int> p1, std::shared_ptr<int> p2){ return *p1 < *p2; } );
@@ -61,7 +61,7 @@ int main()
   std::clock_t emp_start_time = std::clock();
 
   std::vector<emp::Ptr<int>> v_emp(N);
-  for (size_t i = 0; i < N; i++) v_emp[i] = emp::NewPtr<int>((i*7)%N);
+  for (size_t i = 0; i < N; i++) v_emp[i] = emp::NewPtr<int>((int)((i*7)%N));
   std::vector<emp::Ptr<int>> v_emp2(v_emp);
   std::sort( v_emp2.begin(), v_emp2.end(),
              [](emp::Ptr<int> p1, emp::Ptr<int> p2){ return *p1 < *p2; } );

source/base/array.h

@@ -128,6 +128,12 @@ namespace emp {
     array(InputIt first, InputIt last) : base_t(first, last), valid(true) { emp_assert(size() == N); }
     ~array() { valid=false; } // No longer valid when array is deleted.
 
+    operator std::array<T,N>() { 
+      std::array<T,N> ar;
+      for (size_t i = 0; i < N; i++) ar[i] = base_t::operator[](i);
+      return ar;
+    }
+
     constexpr size_t size() const { return N; }
 
     iterator begin() noexcept { return iterator(base_t::begin(), this); }

source/base/vector.h

@@ -10,8 +10,8 @@
  *  This class is a drop-in wrapper for std::vector, adding on bounds checking.
  *  If EMP_NDEBUG is set then it reverts back to std::vector.
  *
- *  @todo Need an automatic conversion from emp::vector to std::vector and back to interface with
- *     non-empirical code.
+ *  @todo Debug code: member functions that take iterators should also take emp iterators that verify
+ *        whether those iterators are valid.
  */
 
 
@@ -62,6 +62,7 @@ namespace emp {
       const vec_t * v_ptr;
       int revision;
 
+      // @CAO: For the moment cannot create an emp iterator from a base since we don't know vector to use.
       // iterator_wrapper(const ITERATOR_T & _in)
       //   : ITERATOR_T(_in), v_ptr(nullptr), revision(0) { ; }
       iterator_wrapper(const ITERATOR_T & _in, const vec_t * _v)

source/meta/type_traits.h

@@ -1,5 +1,5 @@
 //  This file is part of Empirical, https://github.com/devosoft/Empirical
-//  Copyright (C) Michigan State University, 2016-2017.
+//  Copyright (C) Michigan State University, 2016-2018.
 //  Released under the MIT Software license; see doc/LICENSE
 //
 //  Extensions on the standard library type traits to handle Empirical classes

source/tools/set_utils.h

@@ -1,7 +1,7 @@
 /**
  *  @note This file is part of Empirical, https://github.com/devosoft/Empirical
  *  @copyright Copyright (C) Michigan State University, MIT Software license; see doc/LICENSE.md
- *  @date 2016-2017
+ *  @date 2016-2018
  *
  *  @file set_utils.h
  *  @brief Tools to save and load data from classes.
@@ -68,7 +68,7 @@ namespace emp {
     return result;
   }
 
-  /// Compute the set difference of @param s1 and @param s2 (elements that are in S1 but no S2)
+  /// Compute the set difference of @param s1 and @param s2 (elements that are in S1 but not S2)
   template <typename T>
   std::set<T> difference(std::set<T> & s1, emp::vector<T> s2) {
     // Based on PierreBdR's answer to https://stackoverflow.com/questions/283977/c-stl-set-difference

source/web/JSWrap.h

@@ -1,7 +1,7 @@
 /**
  *  @note This file is part of Empirical, https://github.com/devosoft/Empirical
  *  @copyright Copyright (C) Michigan State University, MIT Software license; see doc/LICENSE.md
- *  @date 2015-2017
+ *  @date 2015-2018
  *
  *  @file  JSWrap.h
  *  @brief Wrap a C++ function and convert it to an integer that can be called from Javascript
@@ -116,7 +116,7 @@ namespace emp {
     arg_var = tmp_var;   // @CAO Do we need to free the memory in tmp_var?
   }
 
-  template <int ARG_ID, size_t SIZE, typename T> static void LoadArg(std::array<T, SIZE> & arg_var){
+  template <int ARG_ID, size_t SIZE, typename T> static void LoadArg(emp::array<T, SIZE> & arg_var){
     EM_ASM_ARGS({emp_i.__outgoing_array = emp_i.cb_args[$0];}, ARG_ID);
     pass_array_to_cpp(arg_var);
   }
@@ -265,7 +265,7 @@ namespace emp {
   }
 
   template <typename T, size_t N>
-  static void StoreReturn(const std::array<T, N> & ret_var) {
+  static void StoreReturn(const emp::array<T, N> & ret_var) {
     pass_array_to_javascript(ret_var);
     EM_ASM({ emp_i.cb_return = emp_i.__incoming_array; });
   }
@@ -292,7 +292,7 @@ namespace emp {
   }
 
   template <typename T, size_t N>
-  static void StoreReturn(const std::array<T, N> & ret_var, std::string var) {
+  static void StoreReturn(const emp::array<T, N> & ret_var, std::string var) {
     pass_array_to_javascript(ret_var);
     EM_ASM_ARGS({ emp_i.curr_obj[Pointer_stringify($0)] = emp_i.__incoming_array;}, var.c_str());
   }

source/web/d3/axis.h

@@ -1,5 +1,14 @@
-#ifndef __AXIS_H__
-#define __AXIS_H__
+/**
+ *  @note This file is part of Empirical, https://github.com/devosoft/Empirical
+ *  @copyright Copyright (C) Michigan State University, MIT Software license; see doc/LICENSE.md
+ *  @date 2017-2018
+ *
+ *  @file  axis.h
+ *  @brief Handle drawing of axes on D3 graphts.
+ */
+
+#ifndef EMP_D3_AXIS_H
+#define EMP_D3_AXIS_H
 
 #include "../js_utils.h"
 #include "../../tools/string_utils.h"
@@ -171,7 +180,7 @@ namespace D3 {
     }
 
     template <typename T, std::size_t SIZE>
-    Axis& SetTickValues(std::array<T, SIZE> values) {
+    Axis& SetTickValues(emp::array<T, SIZE> values) {
       emp::pass_array_to_javascript(values);
 
       EM_ASM_ARGS({
@@ -231,7 +240,7 @@ namespace D3 {
     /// transition, then the rescaling will be animated.
     template <typename T>
     Axis& Rescale(double new_min, double new_max, const D3::SelectionOrTransition<T> & svg){
-      this->scale.SetDomain(std::array<double, 2>({{new_min, new_max}}));
+      this->scale.SetDomain(emp::array<double, 2>{{new_min, new_max}});
       ApplyAxis(svg.Select("#"+dom_id));
       return *this;
     }

source/web/d3/dataset.h

@@ -1,5 +1,14 @@
-#ifndef __LOAD_DATA_H__
-#define __LOAD_DATA_H__
+/**
+ *  @note This file is part of Empirical, https://github.com/devosoft/Empirical
+ *  @copyright Copyright (C) Michigan State University, MIT Software license; see doc/LICENSE.md
+ *  @date 2016-2018
+ *
+ *  @file  dataset.h
+ *  @brief Tools to maintain data in D3.
+ */
+
+#ifndef EMP_D3_LOAD_DATA_H
+#define EMP_D3_LOAD_DATA_H
 
 #include <functional>
 
@@ -225,7 +234,7 @@ namespace D3 {
 
     /// Put the last row of the array into arr
     template <std::size_t N, typename T>
-    void GetLastRow(std::array<T, N> & arr) {
+    void GetLastRow(emp::array<T, N> & arr) {
       EM_ASM_ARGS({
         emp_i.__outgoing_array = js.objects[$0][js.objects[$0].length - 1];
       }, GetID());