refactor: cleanup command return statements

Author: devshawn

README.md

@@ -1,6 +1,6 @@
 # kafka-gitops
 
-![Java CI](https://github.com/devshawn/kafka-gitops/workflows/Java%20CI/badge.svg) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](LICENSE)
+![Java CI](https://github.com/devshawn/kafka-gitops/workflows/Java%20CI/badge.svg) [![Maintainability](https://api.codeclimate.com/v1/badges/373371aac3f69c292031/maintainability)](https://codeclimate.com/github/devshawn/kafka-gitops/maintainability) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](LICENSE)
 
 Manage Apache Kafka topics and ACLs through a desired state file.
 

src/main/java/com/devshawn/kafka/gitops/cli/AccountCommand.java

@@ -23,20 +23,16 @@ public Integer call() {
             ParserService parserService = new ParserService(parent.getFile());
             StateManager stateManager = new StateManager(generateStateManagerConfig(), parserService);
             stateManager.createServiceAccounts();
-            return 0;
         } catch (MissingConfigurationException | ConfluentCloudException ex) {
             LogUtil.printSimpleError(ex.getMessage());
-            return 2;
         } catch (ValidationException ex) {
             LogUtil.printValidationResult(ex.getMessage(), false);
-            return 2;
         } catch (KafkaExecutionException ex) {
             LogUtil.printKafkaExecutionError(ex);
-            return 2;
         } catch (WritePlanOutputException ex) {
             LogUtil.printPlanOutputError(ex);
-            return 2;
         }
+        return 2;
     }
 
     private ManagerConfig generateStateManagerConfig() {

src/main/java/com/devshawn/kafka/gitops/cli/ApplyCommand.java

@@ -36,14 +36,12 @@ public Integer call() {
             return 0;
         } catch (MissingConfigurationException ex) {
             LogUtil.printGenericError(ex, true);
-            return 2;
         } catch (ValidationException ex) {
             LogUtil.printValidationResult(ex.getMessage(), false);
-            return 2;
         } catch (KafkaExecutionException ex) {
             LogUtil.printKafkaExecutionError(ex, true);
-            return 2;
         }
+        return 2;
     }
 
     private ManagerConfig generateStateManagerConfig() {

src/main/java/com/devshawn/kafka/gitops/cli/PlanCommand.java

@@ -36,17 +36,14 @@ public Integer call() {
             return 0;
         } catch (MissingConfigurationException ex) {
             LogUtil.printGenericError(ex);
-            return 2;
         } catch (ValidationException ex) {
             LogUtil.printValidationResult(ex.getMessage(), false);
-            return 2;
         } catch (KafkaExecutionException ex) {
             LogUtil.printKafkaExecutionError(ex);
-            return 2;
         } catch (WritePlanOutputException ex) {
             LogUtil.printPlanOutputError(ex);
-            return 2;
         }
+        return 2;
     }
 
     private ManagerConfig generateStateManagerConfig() {

src/main/java/com/devshawn/kafka/gitops/cli/ValidateCommand.java

@@ -28,8 +28,8 @@ public Integer call() {
             return 0;
         } catch (ValidationException ex) {
             LogUtil.printValidationResult(ex.getMessage(), false);
-            return 2;
         }
+        return 2;
     }
 
     private ManagerConfig generateStateManagerConfig() {