Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eflist really slow on osx #36

Open
dgleich opened this issue Sep 6, 2014 · 4 comments
Open

eflist really slow on osx #36

dgleich opened this issue Sep 6, 2014 · 4 comments

Comments

@dgleich
Copy link
Owner

dgleich commented Sep 6, 2014

@yuyongyang800 can you try and reproduce something for me? checkout the branch eflist-refactor. then run eflist_perf ../data/harvard500.offsets 100000

On my mac, this runs at 6000 offsets/sec

On my linux box, this runs at a few million offsets/sec.

Obviously, there is something wrong!

David

@dgleich
Copy link
Owner Author

dgleich commented Sep 6, 2014

My windows box also gives a few million (3M, to be exact.)

@yuyongyang800
Copy link
Collaborator

Let me see what's going on there.

@dgleich
Copy link
Owner Author

dgleich commented Sep 6, 2014

Okay, THANKS!

My quick diagnostic pointed to eflist_get as the place where it's slow (not surprising), but then the issue is ... bit_array_get or select_rank?

Maybe it makes sense to profile those two independently to see which is slower on linux/osx?

@yuyongyang800
Copy link
Collaborator

The bottleneck is the select_rank() function. I am trying to understand why this is so slow on osx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants