Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference manager - access to characters #2505

Open
BiscuitSoda opened this issue Jan 6, 2025 · 4 comments
Open

Reference manager - access to characters #2505

BiscuitSoda opened this issue Jan 6, 2025 · 4 comments
Labels
Bug 🐞 Something isn't working Feature✨

Comments

@BiscuitSoda
Copy link

The problem

Bug desc.:
The Reference Manager does not replace broken references that are in Characters.

For example if you use {Name} as the character display_name, it won't update it when you change the variable name to "player_name".

  • Godot Version 4.3
  • Dialogic Version 2.0-A-16

Solutions

Workaround
Changed it manually in the Character Resource.

Possible fixes
Include character resources in Broken Reference's search and replace

Thank you :)

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Feature✨ labels Jan 6, 2025
@Jowan-Spooner
Copy link
Member

I see. This is annoying but true. Currently the save and replace feature only works on timelines. But there are several other places where variables are allowed, including the Character display name and the glossary entries, titles and extras.

Unfortunately I doubt I will have time to work on this soon, cause it seems a bit complicated for relatively little return (these occurances are much more rare then variable or character name use in timelines).

Still agree this would be nice to have at some point.

@BiscuitSoda
Copy link
Author

No problem and understood!
Thank you for your time and quick response.
I'm a complete noob with no coding experience to speak of, yet I insist on you knowing that I picked up Dialogic very quickly and without issues. I feel it will be a tool I will use a lot in the future, near and far.
It has also helped our project substantially as it allows me to write and "code" at the same time.
Huge time save for us, you have no idea.
This one "bug" is more for my coder friend who had a hell of a time figuring out it was written {Name} in Character Resources (on just one character, the player character) when he was trying to act on {name}.
Whew! XD

Cheers though,
Happy New Years with a bit of delay (call it lag for now)

P.S.
I've noted and passed on that the save and replace only works on timelines.

@BiscuitSoda
Copy link
Author

Also Also,

Maybe warn users that Save and replace only acts on timelines?
(We didn't read too much when we started using Dialogic 🥇, so maybe its written somewhere already haha)

@Jowan-Spooner
Copy link
Member

I just checked and the tooltip of the "Check Selected" button notes that this searches timelines, though this is easy to miss and doesn't specifically highlight that you will have to manually replace things in other resources. Agree that this should be made more prominent.

Jowan-Spooner added a commit that referenced this issue Jan 18, 2025
- Fix for autoskip.disable_on_user_input (due to stupid constant input blocking timers)
- Fix for shortcode syntax highlighting when [] is in parameter content
- Suggest Autoloads, autoload methods and autoload properties in the Set Variable event as well as other related code completion improvements.
- Small crash safeguard
- Implement search highlight in Broken Reference Manager as well as a note on how only timelines are searched/replaced there (see #2505).
- Adds a progress bar to the loading of visual timelines
- Fixes some issues with timeline search
- Changes the saving behaviour when changes have been made to a half-loaded visual timeline and the editor is switched.
   - Previously the timeline would save, meaning everything that hadn't loaded yet was discarded
   - Now the timeline is not saved, meaning the changes made will get lost.
  - Generally changing and saving a timeline before it's fully loaded should not be done. However I think this is better, because it's more likely you accidentally marked the timeline as *changed then actually wanting to keep changes made before saving. 
  - If you let the timeline finish loading, all changes are of course kept.
  
- Does some adjustments to the variable/expression regex. This should hopefully better support nested expressions (e.g. `{Autoload.dictionary[{Player.Name}]}`). This is also reflected in the improved syntax highlighting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Feature✨
Development

No branches or pull requests

2 participants